Skip to content

fix(ci): require auth-config deploy smoke contract - #146

Merged
LucasSantana-Dev merged 1 commit into
mainfrom
fix/deploy-auth-smoke-contract
Mar 10, 2026
Merged

LucasSantana-Dev merged 1 commit into
mainfrom
fix/deploy-auth-smoke-contract

Conversation

@LucasSantana-Dev

@LucasSantana-Dev LucasSantana-Dev commented Mar 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • remove deploy smoke fallback to generic /api/health
  • require /api/health/auth-config to return status=ok
  • fail deploy smoke when auth readiness fields are unhealthy (client/session/redis/callback path)
  • update README + changelog with strict deploy auth-gate contract

Verification

  • npm run lint

Summary by CodeRabbit

  • Chores

    • Enhanced deployment workflow health checks with stricter validation requirements to ensure greater deployment reliability.
  • Documentation

    • Updated documentation to reflect revised deployment health check requirements.

@vercel

vercel Bot commented Mar 10, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lucky Ready Ready Preview, Comment Mar 10, 2026 6:27pm

@netlify

netlify Bot commented Mar 10, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for regal-bunny-0c8efe ready!

Name Link
🔨 Latest commit 479a2a3
🔍 Latest deploy log https://app.netlify.com/projects/regal-bunny-0c8efe/deploys/69b0623820dd3e0009ec06ec
😎 Deploy Preview https://deploy-preview-146--regal-bunny-0c8efe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Mar 10, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The pull request modifies the deploy workflow's health-check validation logic from a two-endpoint approach with fallback to a single /api/health/auth-config endpoint. It introduces stricter JSON validation checks for additional configuration fields and updates corresponding documentation.

Changes

Cohort / File(s) Summary
Deploy Workflow Health-Check
.github/workflows/deploy.yml
Replaces dual-endpoint health-check logic with single auth-config endpoint. Removes 404 fallback handling and adds stricter validation for clientIdConfigured, sessionSecretConfigured, redisHealthy, and redirect URI format checks. Updates error reporting with new field values.
Documentation Updates
CHANGELOG.md, README.md
Documents the stricter deploy workflow health-check requirements for /api/health/auth-config endpoint and its validation criteria.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

size/m

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: enforcing strict auth-config requirements in the CI deploy smoke test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/deploy-auth-smoke-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

This branch was successfully deployed

1 active deployment
Preview — 479a2a3e Deployed Mar 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant