fix(deploy): use project-directory for compose identity by LucasSantana-Dev · Pull Request #142 · LucasSantana-Dev/Lucky

LucasSantana-Dev · 2026-03-10T16:47:39Z

Summary

run compose commands with explicit --project-directory "$COMPOSE_WORKDIR"
keep -p lucky project pinning while avoiding symlink creation under /home
ensure webhook-side compose actions target the same stack identity labels as host-run compose

Validation

bash -n scripts/deploy.sh
compose identity check inside webhook container:
- docker compose --project-directory /home/luk-server/Lucky -p lucky ps

Summary by CodeRabbit

Chores
- Enhanced Docker Compose deployment invocation with explicit project directory specification
- Removed symlink creation logic between working and deployment directories
- Streamlined deployment script execution with simplified directory management for image operations

vercel · 2026-03-10T16:47:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
lucky	Ready	Preview, Comment	Mar 10, 2026 4:48pm

netlify · 2026-03-10T16:47:46Z

✅ Deploy Preview for regal-bunny-0c8efe ready!

Name	Link
🔨 Latest commit	`b0a415f`
🔍 Latest deploy log	https://app.netlify.com/projects/regal-bunny-0c8efe/deploys/69b04b30c2a8c3000829c232
😎 Deploy Preview	https://deploy-preview-142--regal-bunny-0c8efe.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai · 2026-03-10T16:48:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4898405-e33a-4036-b0fc-b5fb589e6ac0

📥 Commits

Reviewing files that changed from the base of the PR and between 0842109 and b0a415f.

📒 Files selected for processing (1)

scripts/deploy.sh

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Quality Gates
GitHub Check: SonarCloud Scan

🧰 Additional context used

📓 Path-based instructions (3)

**/{.scripts,scripts}/**/*.{sh,bash,js,ts}

📄 CodeRabbit inference engine (.cursor/rules/scripts-terminal.mdc)

Use cross-platform deletion utilities instead of OS-specific rm -rf

Files:

scripts/deploy.sh

{scripts/**,packages/scripts/**}

📄 CodeRabbit inference engine (.cursor/rules/lucky-project.mdc)

Prefer packages/scripts or root scripts/ for one-off automation; avoid maintaining one-time scripts in the repository long term

Files:

scripts/deploy.sh

{**/scripts/**,scripts/**,.github/workflows/**/*.{yml,yaml},**/.gitlab-ci.yml,.circleci/config.yml}

📄 CodeRabbit inference engine (.cursor/rules/workflow.mdc)

{**/scripts/**,scripts/**,.github/workflows/**/*.{yml,yaml},**/.gitlab-ci.yml,.circleci/config.yml}: Use cross-platform environment handling in scripts, cross-platform deletion utilities instead of OS-specific commands, pass non-interactive flags (--yes, --ci) by default in automation, and avoid OS-specific commands
Ensure logs are stream-friendly (no pagers) in scripts; when a pager might be used, pipe to cat

Files:

scripts/deploy.sh

🧠 Learnings (3)

📓 Common learnings

Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-09T20:22:47.441Z
Learning: For Docker, compose, and local run operations, use the `lucky-docker-dev` skill

Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-09T20:22:47.441Z
Learning: Use Docker for local development when available via `docker-compose.dev.yml`; prefer scripts in `scripts/` for documented operations

Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.600Z
Learning: Applies to docker-compose.dev.yml : Use Docker for local environment setup when available via `docker-compose.dev.yml`

📚 Learning: 2026-03-09T20:22:47.441Z

Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-03-09T20:22:47.441Z
Learning: Use Docker for local development when available via `docker-compose.dev.yml`; prefer scripts in `scripts/` for documented operations

Applied to files:

scripts/deploy.sh

📚 Learning: 2026-03-09T20:21:08.600Z

Learnt from: CR
Repo: LucasSantana-Dev/Lucky PR: 0
File: .cursor/rules/lucky-project.mdc:0-0
Timestamp: 2026-03-09T20:21:08.600Z
Learning: Applies to docker-compose.dev.yml : Use Docker for local environment setup when available via `docker-compose.dev.yml`

Applied to files:

scripts/deploy.sh

🔇 Additional comments (1)

scripts/deploy.sh (1)

35-40: LGTM!

The addition of --project-directory "$COMPOSE_WORKDIR" ensures Docker Compose uses the correct project directory for stack identity labels. Combined with the explicit -p flag, this correctly addresses the issue where webhook-side compose actions need to match the same stack identity as host-run compose commands.

The variable is properly quoted and only referenced after resolve_compose_workdir() initializes it at line 80.

📝 Walkthrough

Walkthrough

The deployment script's Docker Compose invocation is modified to include an explicit project directory argument. Conditional symlink creation logic between COMPOSE_WORKDIR and DEPLOY_DIR is removed, along with the directory change step prior to pulling images.

Changes

Cohort / File(s)	Summary
Docker Compose Deployment Configuration `scripts/deploy.sh`	Modified `docker_compose` function to include explicit `--project-directory` argument. Removed conditional symlink creation between COMPOSE_WORKDIR and DEPLOY_DIR, and eliminated the `cd` operation prior to pulling images. Operations now execute from DEPLOY_DIR directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

ci, size/m

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding explicit --project-directory flag to docker compose invocations in the deploy script.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/deploy-webhook-project-dir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-03-10T16:48:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-03-10T16:50:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix(deploy): use project-directory for compose identity

b0a415f

github-actions Bot added infra size/s labels Mar 10, 2026

vercel Bot deployed to Preview March 10, 2026 16:48 View deployment

coderabbitai Bot added ci size/m labels Mar 10, 2026

coderabbitai Bot approved these changes Mar 10, 2026

View reviewed changes

LucasSantana-Dev merged commit bd0ad8e into main Mar 10, 2026
15 checks passed

LucasSantana-Dev deleted the fix/deploy-webhook-project-dir branch March 10, 2026 16:51

This was referenced Mar 12, 2026

fix(deploy): stabilize webhook trigger rollout and URL retries #185

Merged

fix(deploy): bake hooks.json into webhook image to bypass VOLUME shadow #261

Merged

LucasSantana-Dev added a commit that referenced this pull request May 13, 2026

fix(deploy): use project-directory for compose identity (#142)

4b13d5e

Navigation Menu

Repository navigation

fix(deploy): use project-directory for compose identity - #142

fix(deploy): use project-directory for compose identity#142
LucasSantana-Dev merged 1 commit into
mainfrom
fix/deploy-webhook-project-dir

LucasSantana-Dev commented Mar 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 10, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented Mar 10, 2026

Uh oh!

sonarqubecloud Bot commented Mar 10, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

LucasSantana-Dev commented Mar 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

vercel Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for regal-bunny-0c8efe ready!

Uh oh!

coderabbitai Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested labels

❌ Failed checks (1 warning)

Uh oh!

sonarqubecloud Bot commented Mar 10, 2026

Quality Gate passed

Uh oh!

sonarqubecloud Bot commented Mar 10, 2026

Quality Gate passed

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

LucasSantana-Dev commented Mar 10, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Mar 10, 2026 •

edited

Loading

netlify Bot commented Mar 10, 2026 •

edited

Loading

coderabbitai Bot commented Mar 10, 2026 •

edited

Loading