Repository navigation
chore(lint): keep no-unsafe at warn pending type-aware ci lint (#1378) - #1387
Conversation
Follow-up to #1385: that PR auto-merged on the promotion commit before the revert landed, so main shipped the no-unsafe-* rules at `error`. The CI `quality / Lint` job runs `eslint .` without db:generate / build:shared, so those type-aware rules report ~4200 phantom "type could not be resolved" errors there — turning that (non-required) job permanently red. Set them back to `warn`; promotion is gated on #1386 (make ci lint type-aware).
|
@cubic-dev-ai please review |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
@LucasSantana-Dev I have started the AI code review. It will take a few minutes to complete. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughESLint configuration downgrades ChangesESLint Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
1 issue found across 1 file
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
No issues found across 1 file
Auto-approved: Reverts five no-unsafe-* rules to warn to avoid false type errors in non-type-aware CI lint job. Config-only, no logic changes.
Re-trigger cubic
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|



Fast follow-up to #1385.
#1385 auto-merged on its promotion commit before the revert push landed, so
mainshipped the fiveno-unsafe-*rules aterrorin the bot/shared ratchet block. The CIquality / Lintjob runseslint .withoutdb:generate/build:shared, so those type-aware rules emit ~4200 phantom "type could not be resolved" / "error typed" diagnostics across untouched files — making that (non-required) job permanently red.This sets the five rules back to
warn. The inventory is still 0 (the #1382/#1384/#1385 fixes stand); only the enforcement is deferred. Promotion is gated on #1386 (make CI lint type-aware: run the Prisma/shared codegen beforeeslint .).Note:
quality / Lintis not a required check, somainstill merges/deploys fine — this just restores a green lint signal. Syntactic rules (import-x/no-duplicates, etc.) are unaffected and remain aterror.Validation
eslint.config.jschanged (5 ruleserror→warn)Summary by cubic
Set the five
@typescript-eslintno-unsafe-*rules back towarnineslint.config.jsto avoid false type errors when CI runseslint .without codegen, keeping thequality / Lintjob green until linting is type-aware. Also updated the inline comment to cite the actual cleanup PRs (#1382/#1384/#1385) and note that promotion toerroris gated on #1386.Written for commit a1e71a6. Summary will update on new commits.
Summary by CodeRabbit
Release Notes