Skip to content

chore(lint): keep no-unsafe at warn pending type-aware ci lint (#1378) - #1387

Merged
LucasSantana-Dev merged 2 commits into
mainfrom
chore/1378-revert-no-unsafe-promotion
Jun 13, 2026
Merged

LucasSantana-Dev merged 2 commits into
mainfrom
chore/1378-revert-no-unsafe-promotion

Conversation

@LucasSantana-Dev

@LucasSantana-Dev LucasSantana-Dev commented Jun 13, 2026 •

Copy link
Copy Markdown
Owner

Fast follow-up to #1385.

#1385 auto-merged on its promotion commit before the revert push landed, so main shipped the five no-unsafe-* rules at error in the bot/shared ratchet block. The CI quality / Lint job runs eslint . without db:generate / build:shared, so those type-aware rules emit ~4200 phantom "type could not be resolved" / "error typed" diagnostics across untouched files — making that (non-required) job permanently red.

This sets the five rules back to warn. The inventory is still 0 (the #1382/#1384/#1385 fixes stand); only the enforcement is deferred. Promotion is gated on #1386 (make CI lint type-aware: run the Prisma/shared codegen before eslint .).

Note: quality / Lint is not a required check, so main still merges/deploys fine — this just restores a green lint signal. Syntactic rules (import-x/no-duplicates, etc.) are unaffected and remain at error.

Validation

  • root lint (typed env) exit 0
  • only eslint.config.js changed (5 rules error → warn)

Summary by cubic

Set the five @typescript-eslint no-unsafe-* rules back to warn in eslint.config.js to avoid false type errors when CI runs eslint . without codegen, keeping the quality / Lint job green until linting is type-aware. Also updated the inline comment to cite the actual cleanup PRs (#1382/#1384/#1385) and note that promotion to error is gated on #1386.

Written for commit a1e71a6. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

Release Notes

  • Chores
    • Adjusted linting configuration to downgrade specific TypeScript type-safety rule severities from errors to warnings. These remain as ratchet warnings pending alignment with CI lint checks.

Follow-up to #1385: that PR auto-merged on the promotion commit before the
revert landed, so main shipped the no-unsafe-* rules at `error`. The CI
`quality / Lint` job runs `eslint .` without db:generate / build:shared, so
those type-aware rules report ~4200 phantom "type could not be resolved"
errors there — turning that (non-required) job permanently red. Set them back
to `warn`; promotion is gated on #1386 (make ci lint type-aware).
@LucasSantana-Dev

Copy link
Copy Markdown
Owner Author

@cubic-dev-ai please review

@vercel

vercel Bot commented Jun 13, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lucky Ready Ready Preview, Comment Jun 13, 2026 6:21am

Request Review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@cubic-dev-ai

cubic-dev-ai Bot commented Jun 13, 2026

Copy link
Copy Markdown

@cubic-dev-ai please review

@LucasSantana-Dev I have started the AI code review. It will take a few minutes to complete.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e1c47d9d-585f-4f5d-ae4e-20addce81a22

📥 Commits

Reviewing files that changed from the base of the PR and between 71f1303 and a1e71a6.

📒 Files selected for processing (1)
  • eslint.config.js

📝 Walkthrough

Walkthrough

ESLint configuration downgrades @typescript-eslint/no-unsafe-* rule severities from error to warn for source packages and adds @typescript-eslint/no-unsafe-argument as warn. Updated comments clarify these rules remain ratchet warnings until the type-aware CI lint job aligns.

Changes

ESLint Configuration Update

Layer / File(s) Summary
Rule severity adjustment and documentation
eslint.config.js
The @typescript-eslint/no-unsafe-assignment, no-unsafe-call, no-unsafe-member-access, and no-unsafe-return rules are downgraded from error to warn for packages/{bot,shared}/src/**/*.ts. The @typescript-eslint/no-unsafe-argument rule is added and set to warn. Explanatory comments are updated to note these remain ratchet warnings pending type-aware CI lint job alignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Suggested labels

ci, bot, size/xs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/1378-revert-no-unsafe-promotion

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LucasSantana-Dev
LucasSantana-Dev enabled auto-merge (squash) June 13, 2026 06:13
@github-actions

Copy link
Copy Markdown

Failed to generate code suggestions for PR

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread eslint.config.js Outdated
cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Jun 13, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Auto-approved: Reverts five no-unsafe-* rules to warn to avoid false type errors in non-type-aware CI lint job. Config-only, no logic changes.

Re-trigger cubic

cubic review: the no-unsafe comment referenced #1378 (the tracking issue) as
if it cleaned the inventory; the actual cleanup landed in #1382/#1384/#1385.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@sonarqubecloud

Copy link
Copy Markdown

@LucasSantana-Dev
LucasSantana-Dev merged commit 7f33b3b into main Jun 13, 2026
39 of 40 checks passed
@LucasSantana-Dev
LucasSantana-Dev deleted the chore/1378-revert-no-unsafe-promotion branch June 13, 2026 06:24

This branch was successfully deployed

1 active deployment
Preview — a1e71a6b Deployed Jun 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant