Repository navigation
fix(webapp): support cloudflare api domain + wildcard cors #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
5a4fb82
fix(auth): prevent vercel oauth loop and harden deploy webhook timeout
LucasSantana-Dev 4406dda
fix(webapp): support cloudflare api domain and wildcard cors
LucasSantana-Dev 9fcb571
chore: resolve main merge conflicts for api-domain cors patch
LucasSantana-Dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: LucasSantana-Dev/Lucky
Length of output: 281
Use
API_BASEfor EventSource and other API endpoints instead of hardcoding/api/paths.The
inferApiBasefunction correctly resolves the API base URL from environment variables with host-based fallbacks. However, hardcoded paths inpackages/frontend/src/services/musicApi.ts(line 74) andpackages/frontend/src/services/api.ts(line 345) bypass this configuration:EventSourceat line 74 hardcodes/api/guilds/${guildId}/music/streamgetConnectUrlat line 345 hardcodes/api/lastfm/connectThese will fail when the frontend and backend are on different origins. Replace with
${API_BASE}/guilds/${guildId}/music/streamand similar patterns.🧰 Tools
🪛 GitHub Check: SonarCloud Code Analysis
[warning] 26-26: Prefer
globalThisoverwindow.See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Nexus&issues=AZzVSEqguXUW7gR7dkbB&open=AZzVSEqguXUW7gR7dkbB&pullRequest=126
[warning] 27-27: Prefer
globalThisoverwindow.See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Nexus&issues=AZzVSEqguXUW7gR7dkbC&open=AZzVSEqguXUW7gR7dkbC&pullRequest=126
[warning] 25-25: Prefer
globalThis.windowoverwindow.See more on https://sonarcloud.io/project/issues?id=LucasSantana-Dev_Nexus&issues=AZzVSEqguXUW7gR7dkbA&open=AZzVSEqguXUW7gR7dkbA&pullRequest=126
🤖 Prompt for AI Agents