Repository navigation
fix(auth): stop vercel oauth infinite loop - #125
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for regal-bunny-0c8efe ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR fixes Vercel API routing loops by removing the rewrites configuration and adds support for configurable frontend API base URLs via the VITE_API_BASE_URL environment variable. It also tightens curl timeout settings in the deploy workflow and updates corresponding documentation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Size Change: +13 B (0%) Total Size: 291 kB
ℹ️ View Unchanged
|
|
This was referenced Mar 10, 2026
LucasSantana-Dev
added a commit
that referenced
this pull request
May 13, 2026
Remove self-referential Vercel API rewrite, add VITE_API_BASE_URL support, and enforce deploy webhook curl timeouts.
4 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/apirewrite that caused508 INFINITE_LOOPVITE_API_BASE_URLsupport so hosted frontend can target a dedicated backend API originRoot Cause
vercel.jsonrewrote/api/:path*tohttps://lucky.lucassantana.tech/api/:path*.When the same custom domain was attached to Vercel, auth requests looped through Vercel and returned
508 INFINITE_LOOP.Validation
npm run type:check --workspace=packages/frontendpython3+yaml.safe_loadnpm run lint --workspace=packages/frontendcurrently fails from existing repo-wide ESLint parser/config issues unrelated to this patchSummary by CodeRabbit
Release Notes
Bug Fixes
New Features
Documentation