Stream multipart bodies from files #593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This is the first part of enabling streamed responses. This includes a ton of scaffolding, so the rest of the feature will be easy to implement. If a multipart form has a field whose value is a single-chunk template, and the root of the expression is a
file()call it will be streamed to the server rather than loaded into memory. For example:Closes #582
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
The tests rely on a PR I made to reqwest, which may or may not get merged. If it's not merged+released by the time this is ready to be published, I'll have to figure out another solution for the tests.
QA
How did you test this?
Lots of unit tests, tested the preview stuff in the TUI.
Checklist
CONTRIBUTING.mdalready?CHANGELOG.md?