feat(Innertube)!: Add GetVideoInfoOptions to support content bound PoTokens
#994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proposal to get comments
getInfoandgetBasicInfoshould be using content bound poTokens. So that means these calls will need to take a poToken as an argument.I added
GetVideoInfoOptions- while it is a breaking change, but avoids the need for breaking again if/when new options are needed for these operations.Not providing content bound poToken will fallback to session poToken, I believe that should have better results than no token at all.
BEGIN_COMMIT_OVERRIDE
feat(Innertube)!: Add
GetVideoInfoOptionsto support content bound PoTokens (#994)BREAKING CHANGE: The second parameters of
Innertube.getInfo()andInnertube.getBasicInfo()have changed to an object, that means thatInnertube.getInfo('jNQXAC9IVRw', 'MWEB')becomesInnertube.getInfo('jNQXAC9IVRw', { client: 'MWEB' })andInnertube.getBasicInfo('jNQXAC9IVRw', 'MWEB')becomesInnertube.getBasicInfo('jNQXAC9IVRw', { client: 'MWEB' }). The same applies to thegetInfomethod in theMusicandKidsclient classes.END_COMMIT_OVERRIDE