Skip to content

fix: return empty response to textDocument/formatting if no changes #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025
Merged

fix: return empty response to textDocument/formatting if no changes #3142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa273e3
fix: return empty response to textDocument/formatting if no changes
danielleontiev Mar 30, 2025
0431762
Merge branch 'master' into text-document-format-no-changes
sumneko Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `FIX` prevent unnecessary edits by LSP formatting when content did not change

## 3.13.9
`2025-3-13`
Expand Down
4 changes: 4 additions & 0 deletions script/core/formatting.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ return function(uri, options)
return
end

if text == formattedText then
return
end

return {
{
start = state.ast.start,
Expand Down
Loading