Skip to content

fix: default path for --doc_out_path is the current directory #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025
Merged

fix: default path for --doc_out_path is the current directory #3076

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db0633e
fix: default path for --doc_out_path is the current directory
AndreasMatthias Feb 12, 2025
8a6fbd3
Merge branch 'master' into fix_doc_defaultpath
AndreasMatthias Feb 14, 2025
a9db22d
fix: mistake in latest merge
AndreasMatthias Feb 14, 2025
ee654a2
Merge branch 'master' into fix_doc_defaultpath
sumneko Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argument
* `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argumen
Copy link
Contributor

@tomlau10 tomlau10 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seems modified the wrong line
(you incorrectly removed the t from the word argument)

Copy link
Contributor Author

@AndreasMatthias AndreasMatthias Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This was a mistake.

* `CHG` default path for `--doc_out_path` is the current directory
* `FIX` remove extra `./` path prefix in the check report when using `--check=.`

## 3.13.6
Expand Down
4 changes: 4 additions & 0 deletions script/cli/doc/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@ function doc.runCLI()
end)
io.write('\x0D')

if not DOC_OUT_PATH then
DOC_OUT_PATH = fs.current_path():string()
end

local ok, outPaths, err = dirty_export.serializeAndExport(docs, DOC_OUT_PATH)
print(lang.script('CLI_DOC_DONE'))
for i, path in ipairs(outPaths) do
Expand Down