Fix vararg indices being unknown when iterated #2908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @tomlau10 for basically writing the fix for me.
After some testing and trying any weird thing I could think of to break the fix, it seemed pretty bulletproof, but I wouldn't be surprised if I'm just not creative enough.
I went ahead and added a test and an entry to the changelog.
This is my first time contributing to luals, so I'd love constructive feedback. Like I feel like my wording is bad no matter how I think about wording things 😁
FIXES #2906