-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect CompletionItemKind
for postfix snippets
#2773
Conversation
Well for many clients apart from vscode users configure these icons themselves and imo this is just wrong. E.g. if someone would want to implement a filter function for kinds this would be really confusing. |
Is there any way to configure or customize that locally in your editor? It'd be much better for this to be semantically correct, but it's your call at the end of the day. For example, with the way it is now:
|
Seems customizing intellisense icons has long been proposed in vscode, but the issue got closed and not implemented in the end |
Oh I just found that there are I followed the video above and installed a Material Product Icons extension, and the suggestion icons just feel much better 😂 . Especially the snippet icon, which in the default theme it looks like a Below shows the before after differences:
I suggest @sumneko can test it out, and I vote for "It'd be much better for this to be semantically correct" 👍 |
Please also fix the tests |
01827b4
to
30fef47
Compare
Awesome, thanks for fixing this! |
No description provided.