-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: resolve links to symbols in markdown descriptions #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Links like [mySymbol](lua://mySymbol) in a comment will now be resolved to a URI pointing to the actual file where `mySymbol` can be found.
carsakiller
added
the
feat/LuaCats Annotations
Related to Lua Language Server Annotations (LuaCats)
label
May 8, 2024
@sumneko, would you be able to assist me in adding completion to the |
See
|
carsakiller
force-pushed
the
2175-md-symbol-reference
branch
from
May 23, 2024 05:50
6d18020
to
1f3a500
Compare
carsakiller
commented
May 23, 2024
Okay, should be good to go 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links like
[mySymbol](lua://mySymbol)
in a comment will now be resolved to a URI pointing to the actual file wheremySymbol
can be found.I would also like to add highlighting and completion while you are writing so that
[something](lua://
triggers completion of symbols – but I'm not sure where to even start for that.This change will result in
@see
being pretty much useless. I never really used@see
much due to formatting issues and it not looking quite right. Perhaps@see
should be removed?Closes #2175