Added How to use Coil Image Loading Library.#117
Conversation
|
please review and let me know of the changes @jmfayard |
|
@jmfayard please review |
|
I have updated the code as per your suggestions and have added the commit, please review it @jmfayard |
| private var ivFile: ImageView? = null | ||
| private var ivUrl: ImageView? = null | ||
| private var ivDrawable: ImageView? = null |
There was a problem hiding this comment.
@LouisCAD do you think those views should be nullable? I know nothing about Android
There was a problem hiding this comment.
If not nullable, we can initialize them later, but if we use lateinit, there might be possibility of views not being initialized, which would lead to crash of the application, so, i think this nullable would handle it correctly, since we are using a null operator while accessing the views.
| import java.io.File | ||
|
|
||
|
|
||
| class CoilFragment : Fragment() { |
There was a problem hiding this comment.
Can you add links to the project repo and documentation?
That will greatly add new comers
There was a problem hiding this comment.
I have now added the references.
|
you can have a look @jmfayard |
Closes #52