tr2/inject: add item and room editing support #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds injection support for changing item positions and angles.
This fixes doors in Ice Palace and Floating Islands that are positioned/rotated incorrectly such that they cause an invisible wall on the wrong side. Resolves LostArtefacts#1963.
This extends the Gong Hammer's pickup trigger into the adjacent tile to ensure it is detected regardless of Lara's position. Resolves LostArtefacts#1716.
This adds a new floor data fix type to allow editing room properties, currently limited to room flags.
This floods room 98 in Wreck of the Maria Doria. Resolves LostArtefacts#1939.
lahm86
added
OG bug
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
rr-
approved these changes
Nov 28, 2024
aredfan
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1716.
Resolves #1939.
Resolves #1963.
Checklist
Description
This fixes a few more FD issues as detailed in the issues. I've bundled the door fixes for Ice Palace and Floating Islands in as FD fixes too, even though they involve repositioning items. Given the issue they cause, it feels more natural coming under the FD fix config setting.
The item editing function will also be used later for #1613.
Ref: LostArtefacts/TRXInjectionTool#13