Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes related to live changing of save slots; support disabling save slots completely #1955

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix crashes related to live changing of save slots; support disabling save slots completely #1955

merged 2 commits into from
Nov 25, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Nov 25, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1954.

@rr- rr- added TRX bug A bug with TRX TR1 labels Nov 25, 2024
@rr- rr- self-assigned this Nov 25, 2024
@rr- rr- requested review from a team as code owners November 25, 2024 15:31
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team November 25, 2024 15:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 25, 2024 •
edited
Loading

Download the built assets for this pull request:

@rr-
Copy link
Collaborator Author

rr- commented Nov 25, 2024

When issuing /set save-slot 0 and later trying to save or load, the game should handle this gracefully by either allowing to restart the current level, or playing the game from scratch. This can be triggered from many contexts:

  • Esc menu, navigate to the lower ring, open passport manually
  • F5 quick save
  • F6 quick load
  • Title screen

I still am experiencing some crashes when trying to change live to slot count 0, but I'll get around this.

@rr- rr- force-pushed the issue-1954-savegame-slot-set-crashes branch from aa6789f to 9849525 Compare November 25, 2024 15:46
@rr-
Copy link
Collaborator Author

rr- commented Nov 25, 2024

Should be good now.

@aredfan
Copy link
Collaborator

aredfan commented Nov 25, 2024

These steps trigger a crash:

  1. /set save-slot 25
  2. Go into the save dialog
  3. Scroll down and highlight any save slot in the range of 21-25
  4. /set save-slot 20

@rr- rr- force-pushed the issue-1954-savegame-slot-set-crashes branch from 9849525 to 2ec8a6f Compare November 25, 2024 16:33
@rr-
Copy link
Collaborator Author

rr- commented Nov 25, 2024

@aredfan thank you for thorough testing – should be fixed now.

@rr- rr- force-pushed the issue-1954-savegame-slot-set-crashes branch from 2ec8a6f to 84765f8 Compare November 25, 2024 16:35
@rr- rr- merged commit 932b1e7 into develop Nov 25, 2024
7 checks passed
@rr- rr- deleted the issue-1954-savegame-slot-set-crashes branch November 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aredfan aredfan aredfan approved these changes

@lahm86 lahm86 Awaiting requested review from lahm86 lahm86 is a code owner automatically assigned from LostArtefacts/dev

@walkawayy walkawayy Awaiting requested review from walkawayy walkawayy is a code owner automatically assigned from LostArtefacts/dev

Assignees

@rr- rr-

Labels
TR1 TRX bug A bug with TRX
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TR1X bug: changing save slot count when the game is running is dangerous
2 participants
@rr- @aredfan