config_tool: add support for searching #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a search box to the config tool to allow filtering properties by keywords. Resolves LostArtefacts#1889.
lahm86
requested review from
rr- and
walkawayy
and removed request for
a team
|
Download the built assets for this pull request: |
aredfan
approved these changes
Nov 16, 2024
walkawayy
approved these changes
Nov 16, 2024
rr-
approved these changes
Nov 16, 2024
2 tasks
|
Oh wow @lahm86, thank you so much for deciding to do this so quickly. It works beautifully. Especially love how it turns red and signals the user a term yielded no results. It's super quick and intuitive to use, and instantly made me find the things I was looking for ❤️ |
Thank you for trying it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1889.
Checklist
Description
This adds a search box to the config tool to allow filtering properties by keywords. The matching logic is very simple: if a property's title or description contains any of the search keywords, it's shown. No weighting or ordering is performed.