Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accents in Spanish words #1919

Closed
antonio3687 opened this issue Nov 18, 2024 · 9 comments · Fixed by #1933
Closed

Accents in Spanish words #1919

antonio3687 opened this issue Nov 18, 2024 · 9 comments · Fixed by #1933
Assignees
Labels
Support No code changes necessary TR1

Comments

@antonio3687
Copy link

antonio3687 commented Nov 18, 2024

4 6
4 5 1

Good afternoon, the accents in the Spanish words have disappeared, I attach two images, one that works in the final version 4.5.1 and one that does not work in version 4.6.
How do you play at the demo level?
Thank you very much.

@rr-
Copy link
Collaborator

rr- commented Nov 18, 2024

Hi @antonio3687 as per the release notes, the accents need to be adjusted:

  • \{umlaut}
  • \{hat}
  • \{acute accent}
  • \{grave accent}

Unfortunately, there's currently no official support for the translated content so any changes to the gameflow files need to be presently made by hand.

@rr- rr- added Support No code changes necessary TR1 labels Nov 18, 2024
@antonio3687
Copy link
Author

Hi, can you give me an example of what it would look like? And is playing at the demo level by commands? Best regards.

@lahm86
Copy link
Collaborator

lahm86 commented Nov 18, 2024

You can place the accent before the letter as follows in the gameflow:

"INV_ITEM_COMPASS": "Br\\{acute accent}ujula",

For playing the demo, there is information in #1378. You pass -demo_pc at the command line, but you will also need to acquire the demo PHD files and put them in a folder named data_demo_pc (see the demo gameflow).

@antonio3687
Copy link
Author

Good evening, there is nothing for the letter ñ, is there? Thank you very much for the example of the accent and I have already been able to play the demo level. Thank you very much and best regards.

@Wronschien
Copy link

Hello, how comes entities must start with a double \ when the changelog in the release only states single \ ?

@lahm86
Copy link
Collaborator

lahm86 commented Nov 19, 2024

Good evening, there is nothing for the letter ñ, is there? Thank you very much for the example of the accent and I have already been able to play the demo level. Thank you very much and best regards.

Only the original accents are currently supported (these are the only glyphs available in the original level files).

@lahm86
Copy link
Collaborator

lahm86 commented Nov 19, 2024

Hello, how comes entities must start with a double \ when the changelog in the release only states single \ ?

This is standard in JSON (and programming in general) when you want the \ to be part of the string, which it must be for the game to recognise it. If it were a single \ within the quotes, it would be treated as an escape character, and I don't think the gameflow would even load as it would be parsed as invalid.

@Wronschien
Copy link

Oh I see, I don't know much about json and didn't know that this had to be escaped. Maybe this should be added in the changelog ?
Thanks for the reply.

@rr-
Copy link
Collaborator

rr- commented Nov 19, 2024

I don't think a changelog entry is necessary for this change. The "\\" works as expected: it appears as \ onscreen (as it used to be the case). Only if it's followed by a recognized sequence like "\\{umlaut}", it will be replaced with an umlaut.

rr- added a commit that referenced this issue Nov 24, 2024
rr- added a commit that referenced this issue Nov 24, 2024
@rr- rr- linked a pull request Nov 24, 2024 that will close this issue
2 tasks
@rr- rr- closed this as completed in #1933 Nov 24, 2024
rr- added a commit that referenced this issue Nov 24, 2024
@rr- rr- self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support No code changes necessary TR1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants