Amm v2 - Exit mode and pool reuse #2450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dong77
reviewed
Jun 4, 2021
dong77
approved these changes
Jun 5, 2021
Brechtpd
added a commit
that referenced
this pull request
Jun 5, 2021
* [AMM] Fix pools with active asset manager * Feedback * Amm v2 - Exit mode and pool reuse (#2450) * AMM v2 - minor improvement over brecht's code (#2458) Co-authored-by: Daniel Wang <[email protected]>
Brechtpd
added a commit
that referenced
this pull request
Jun 8, 2021
* [protocol 3] Initial commit amm v2 * [protocol 3.8] Amm v2 improvements * Small improvements * Small simplification * Update AmmData.sol * Amm v2 - AssetManager fix (#2445) * [AMM] Fix pools with active asset manager * Feedback * Amm v2 - Exit mode and pool reuse (#2450) * AMM v2 - minor improvement over brecht's code (#2458) Co-authored-by: Daniel Wang <[email protected]> * Amm v2 improve2 (#2462) * Update AmplifiedAmmController.sol * Update AmplifiedAmmController.sol * AMM v2: minor improvements (#2466) Co-authored-by: Daniel Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2449
Allows the controller to enter exit mode, which allows the operator to exit users from the pool if no fee needs to be paid.
Also allows the controller to re-use the pool with different tokens when the supply is
0.I used the controller as the authorized address because pools currently don't have an owner and exit mode/pool re-using a pool even with no supply may not work for all types of pools.
Made
permitpublic to make the Pool contract smaller because the contract size was too large.