[hebao][audit] issue 8 #1186
Merged
[hebao][audit] issue 8 #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dong77
previously approved these changes
May 23, 2020
Brechtpd
previously approved these changes
May 23, 2020
dong77
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way the VM provides gas to external calls since EIP 150 ws implemented, if the external call is executed with less gas than the gasSettings.limit, only 63/64 of the available gas will be provided, allowing for the relayer to force transactions with a limit lower than the one set by the user.
A discussion around this issue is available at safeTxGas is not enforced safe-global/safe-smart-account#100
Recommendation
Require that the gas available after the call is greater than than 65/64 of the user provided gasSettings.limit.
For reference: Implementation of the fix by the Gnosis Safe team: safe-global/safe-smart-account@62d4bd3 ca
We followed the recommendation from solidified and add 40000 extra gas requirements.