Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2218 add emoji to foodType on watch #2230

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Joerg-Schoemer
Copy link
Contributor

@Joerg-Schoemer Joerg-Schoemer commented Sep 22, 2024

Purpose

This PR fixes Issue #2218

Signed-off-by: Jörg Schömer <[email protected]>
@Joerg-Schoemer Joerg-Schoemer changed the title #2218 add emoji to foodType #2218 add emoji to foodType on watch Sep 23, 2024
@marionbarker
Copy link
Contributor

Test

I tested this on my personal Loop phone. (iPhone 15 pro running iOS 18.3.2 with Loop 3.4.4)

Confirm bug

First, I entered carbs from watch using pizza icon.

  • The icon was not shown in the ICE screen.

Confirm fix

I then modified my code using this change and rebuilt.

  • I removed Loop from my watch complications (which allows new Loop app to install on the watch)
  • After installation, I added Loop back to my watch complications
  • I entered carbs from watch using pizza icon.
  • The pizza icon now shows up on the ICE screen

Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code change and tested.
LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants