Pie chart feature #3
Conversation
| (d3-attr 'y' (pipe outputAccessor yScale)) | ||
| (d3-attr 'height' (pipe outputAccessor yScale (bar-height height))) | ||
| ) | ||
| enter=(pipe |
There was a problem hiding this comment.
can you please revert the changes to this file? they shouldn't be in this PR
There was a problem hiding this comment.
yep, will resolve in the next commit
|
addresses #13 |
|
|
||
| export function emberSparklesArc([ radius ], textLabel=false) { | ||
| if (textLabel === true){ | ||
| return arc().outerRadius(radius - 40).innerRadius(radius - 40); |
There was a problem hiding this comment.
we will want to pass outerRadius and innerRadius arguments to this helper instead of hardcoding their inputs
There was a problem hiding this comment.
this means we will be able to remove the if (textLabel...) part (since the arguments will be different depending on whether these are text labels or not)
|
@taras can you review this PR please? The pie chart is fully functional now |
|
|
||
| this.setProperties({ data, domain }); | ||
|
|
||
| assert.equal(this.$('path').length, 4, 'There are the correct number of arcs after the data is updated'); |
There was a problem hiding this comment.
I know that checking the data bound to each arc is very hard to do - instead, can you also check the arc percentages as a proxy for this?
|
I get this error when I click around the pie chart.
I did some googling. It looks like you need a custom tween for this. http://stackoverflow.com/a/21287079/172894 |
|
Looks great! |
ghost
merged commit
|
closes #3 |
ghost
mentioned this pull request
…h-pages * 'master' of github.com:LocusEnergy/ember-sparkles: (88 commits) Released v0.4.7 Pie chart feature (#3) Removed use of map and d3-get (#19) Reactive helpers (#18) Released v0.4.6 removes unused code Released v0.4.5 sets up demo site (#17) updates node version fixes CI config upgrades ember-cli, adds ember-cli-eslint Released v0.4.4 adds ember-cli-release config adds ember-try Released v0.4.3 uses v0.9 of ember-cli-d3-shape and v0.5.1 of ember-d3-helpers (#15) 0.4.2 Refines axis filter, makes vertical axis label responsive (#16) 0.4.1 filters ticks based on integer input (#14) ...
No description provided.