Skip to content

create pr against sunshine#53

Merged
ReenigneArcher merged 1 commit intonightlyfrom
add/create-pr-against-sunshine
Dec 23, 2022
Merged

create pr against sunshine#53
ReenigneArcher merged 1 commit intonightlyfrom
add/create-pr-against-sunshine

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 22, 2022

Description

  • create a pr against sunshine
    • This will update all ffmpeg submodules in a single PR, whereas dependabot creates a PR for every submodule branch, which generates a ton of workflow runs for Sunshine. This PR aims to reduce the workflow runs. Additionally it will be much faster to merge the changes into Sunshine as checks will only need to pass on a single PR instead of multiple.

📝 This depends on a fork of an action to enable PRs against another repository. Once this PR is merged, the workflow can be changed back to the original maintainer. repo-sync/pull-request#69

Todo:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the add/create-pr-against-sunshine branch 14 times, most recently from 4558a19 to 6c74943 Compare December 22, 2022 03:31
@ReenigneArcher ReenigneArcher force-pushed the add/create-pr-against-sunshine branch 2 times, most recently from 22f90d6 to a8953d7 Compare December 22, 2022 04:35
@ReenigneArcher ReenigneArcher force-pushed the add/create-pr-against-sunshine branch 4 times, most recently from 02b8d86 to 24c4069 Compare December 23, 2022 00:02
@ReenigneArcher
Copy link
Member Author

An issue was discovered.

The destination branch on sunshine still existed (although the previous PR was merged), and a new PR was created.

The destination branch looked like this when the PR was created.
image

Missing new commits from nightly.
image

@ReenigneArcher ReenigneArcher force-pushed the add/create-pr-against-sunshine branch 5 times, most recently from 859c770 to ad454b5 Compare December 23, 2022 01:22
@ReenigneArcher ReenigneArcher force-pushed the add/create-pr-against-sunshine branch 4 times, most recently from 748a9fe to f5479f5 Compare December 23, 2022 01:46
@ReenigneArcher ReenigneArcher force-pushed the add/create-pr-against-sunshine branch from f5479f5 to c80724b Compare December 23, 2022 14:21
@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 23, 2022 14:46
@ReenigneArcher ReenigneArcher merged commit e6412fa into nightly Dec 23, 2022
@ReenigneArcher ReenigneArcher deleted the add/create-pr-against-sunshine branch December 23, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants