Add XTest input fallback#997
Merged
ReenigneArcher merged 13 commits intoLizardByte:nightlyfrom Mar 8, 2023
Doridian:xinput
Merged
Add XTest input fallback#997ReenigneArcher merged 13 commits intoLizardByte:nightlyfrom Doridian:xinput
ReenigneArcher merged 13 commits intoLizardByte:nightlyfrom
Doridian:xinput
Conversation
|
Your PR was set to |
Member
|
Are you on our discord server so we can discuss this in real time? |
Contributor
Author
|
@ReenigneArcher Just joined, same name as on GitHub. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes a way for Sunshine to utilize XTest for inputs in the event libev/uinput is unavailable (such as inside an un-privileged Docker container)
Let me know how this looks code-wise. Likely the direct calling of X functions needs to be changed, considering you seem to use theDonedyn::loadsemantics elsewhere.This also removes the useless
pressedinteger (grabbing the value out of the array creates a copy, sopressedwas never actually anything but0)It also removes the loops in
init_keycodes, most of which were useless (as they were all explicitly mentioned via__CONVERT), and replaces them with full explicit key constants.Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.