Skip to content

PWA Improvements#980

Closed
DanTheMan827 wants to merge 2 commits intoLizardByte:nightlyfrom
DanTheMan827:add-svg
Closed

PWA Improvements#980
DanTheMan827 wants to merge 2 commits intoLizardByte:nightlyfrom
DanTheMan827:add-svg

Conversation

@DanTheMan827
Copy link

Description

This PR adds an SVG image for the logo as well as various icons. It also adds meta tags to direct iOS to run the PWA in full screen when added to the home screen.

Rather than create multiple methods for each new image in the images directory, I copied the method for node_modules and adjusted it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few requested changes, and questions. Once you make these changes, I also want to get some feedback from some of the other devs, I'm not yet sure how I feel about loading all these images into the repo.

@DanTheMan827
Copy link
Author

DanTheMan827 commented Mar 12, 2023

Here’s a package from realfavicongenerator.com favicon_package_v0.16.zip

What do you think of this?

@DanTheMan827
Copy link
Author

I've force pushed the branch to use the set from https://realfavicongenerator.net instead.

@DanTheMan827
Copy link
Author

@ReenigneArcher What about this with the changes made?

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Mar 18, 2023

@DanTheMan827 I will review again after #972 as that PR requires the same c++ changes to confighttp

There are also some conflicts that need to be resolved here, but probably easier to wait until #972 is merged.

@LizardByte-bot
Copy link
Member

This PR is stale because it has been open for 90 days with no activity. Comment or remove the stale label, otherwise this will be closed in 10 days.

@LizardByte-bot
Copy link
Member

This PR was closed because it has been stalled for 10 days with no activity.

@DanTheMan827
Copy link
Author

Waiting on other PR

@LizardByte-bot
Copy link
Member

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

@LizardByte-bot
Copy link
Member

This PR was closed because it has been stalled for 10 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants