Conversation
ReenigneArcher
left a comment
There was a problem hiding this comment.
I have a few requested changes, and questions. Once you make these changes, I also want to get some feedback from some of the other devs, I'm not yet sure how I feel about loading all these images into the repo.
|
Here’s a package from realfavicongenerator.com favicon_package_v0.16.zip What do you think of this? |
(cherry picked from commit 61a21b2)
|
I've force pushed the branch to use the set from https://realfavicongenerator.net instead. |
|
@ReenigneArcher What about this with the changes made? |
|
@DanTheMan827 I will review again after #972 as that PR requires the same c++ changes to confighttp There are also some conflicts that need to be resolved here, but probably easier to wait until #972 is merged. |
|
This PR is stale because it has been open for 90 days with no activity. Comment or remove the stale label, otherwise this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
|
Waiting on other PR |
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
|
This PR was closed because it has been stalled for 10 days with no activity. |
Description
This PR adds an SVG image for the logo as well as various icons. It also adds meta tags to direct iOS to run the PWA in full screen when added to the home screen.
Rather than create multiple methods for each new image in the images directory, I copied the method for node_modules and adjusted it.
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.