Add setting for suppressing input from mouse, keyboard, or gamepads#941
Merged
ReenigneArcher merged 2 commits intoLizardByte:nightlyfrom Mar 8, 2023
Merged
Conversation
|
Your PR was set to |
090f2c1 to
58aeb57
Compare
ReenigneArcher
requested changes
Feb 21, 2023
Member
ReenigneArcher
left a comment
There was a problem hiding this comment.
Thank you for this PR! This will be a nice feature to add.
I would like to ask for a small adjustment though.
7ad6a5c to
40b9afb
Compare
ReenigneArcher
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds three new settings that allow suppressing client input from the mouse, keyboard, and gamepads, one for each type of input. They can be toggled individually, allowing any combination of allowable input the user desires. This also allows for disabling client input entirely, putting Sunshine in a "view only" mode.
All settings are disabled by default, meaning there's no change in default behavior.
This feature was suggested here: https://github.com/LizardByte/Sunshine/discussions/822
Screenshot
Issues Fixed or Closed
N/A
Type of Change
.github/...)Checklist
Notes: code additions are very simple and I consider them sufficiently self explanatory to not require any comments.
I have not added any new methods or components.
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.