Skip to content

Fix hwdevice being destroyed before context causing sigsegv on AMD #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 2 commits into from
Mar 13, 2022
Merged

Fix hwdevice being destroyed before context causing sigsegv on AMD #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a31c6c4
Fix hwdevice being destroyed before context, causing a sigsegv becaus…
HomerSp Mar 9, 2022
6fca2c5
Use session_t destructor to ensure the context and hwdevice are alway…
HomerSp Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sunshine/video.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ class session_t {
session_t(ctx_t &&ctx, std::shared_ptr<platf::hwdevice_t> &&device, int inject) : ctx { std::move(ctx) }, device { std::move(device) }, inject { inject } {}

session_t(session_t &&other) noexcept = default;
~session_t() {
// Order matters here because the context relies on the hwdevice still being valid
ctx.reset();
device.reset();
}

// Ensure objects are destroyed in the correct order
session_t &operator=(session_t &&other) {
Expand Down