Skip to content

Move the check for UPnP enabled up to avoid error messages #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Jan 10, 2023
Merged

Move the check for UPnP enabled up to avoid error messages #748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/upnp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ static std::string_view status_string(int status) {
}

std::unique_ptr<platf::deinit_t> start() {
if(!config::sunshine.flags[config::flag::UPNP]) {
return nullptr;
}

int err {};

device_t device { upnpDiscover(2000, nullptr, nullptr, 0, IPv4, 2, &err) };
Expand Down Expand Up @@ -128,10 +132,6 @@ std::unique_ptr<platf::deinit_t> start() {
}
}

if(!config::sunshine.flags[config::flag::UPNP]) {
return nullptr;
}

auto rtsp = std::to_string(map_port(stream::RTSP_SETUP_PORT));
auto video = std::to_string(map_port(stream::VIDEO_STREAM_PORT));
auto audio = std::to_string(map_port(stream::AUDIO_STREAM_PORT));
Expand Down