Migrate Windows config files into specific config directory#716
Merged
ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom Jan 7, 2023
Merged
Migrate Windows config files into specific config directory#716ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom
ReenigneArcher merged 3 commits intoLizardByte:nightlyfrom
Conversation
814e755 to
68b0a2b
Compare
Contributor
brad-richardson
left a comment
There was a problem hiding this comment.
Worked for me upgrading from v0.16, just one question
5ea71a0 to
8c0a1f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This moves config and other data files out of the root of our Program Files directory into a specific
configdirectory. Only that new config directory has RW access for the Users group now.I've tested this locally, but it would be nice for someone else to grab the installer from the CI job to make sure it all works seamlessly for them too.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.