Generated app id with hashed input data#715
Merged
ReenigneArcher merged 8 commits intoLizardByte:nightlyfrom Jan 7, 2023
Merged
Generated app id with hashed input data#715ReenigneArcher merged 8 commits intoLizardByte:nightlyfrom
ReenigneArcher merged 8 commits intoLizardByte:nightlyfrom
Conversation
cgutman
reviewed
Jan 6, 2023
cgutman
reviewed
Jan 7, 2023
Collaborator
cgutman
left a comment
There was a problem hiding this comment.
Other than the leak, LGTM
85f08d1 to
5bc154a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generate stable app id based on name and image data hash. This allows us to stop persisting ids altogether and prevents us filling up moonlight's cache if ids are changing often.
To test:
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.