Fix streaming with non-B8G8R8A8 desktop mode#609
Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom Dec 23, 2022
Merged
Fix streaming with non-B8G8R8A8 desktop mode#609ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
Conversation
This was referenced Dec 22, 2022
Contributor
|
I missed some discussion in discord before leaving my last comment on #522 referring to this PR. After looking at the code and testing a build, I can see that this works independently to #522, and also is a simpler & much superior fix not only towards getting HDR to display something, but also getting @ReenigneArcher: if @cgutman is happy with this PR, I recommend merging it (and ignoring #522 entirely). Even though HDR needs more work, this is still a legitimate fix for #553. |
d7eaf9b to
06a753c
Compare
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We had an incorrect assumption that the DXGI format of the mode in
DXGI_OUTDUPL_DESCwas the format of the frames that we will receive fromAcquireNextFrame().This is incorrect as MSDN states:
This is why we thought we were getting formats like
DXGI_FORMAT_R16G16B16A16_FLOAT(in HDR) andDXGI_FORMAT_R8G8B8A8_UNORM(in Vulkan apps). This change "fixes" streaming with HDR enabled (though output is clipped to SDR, causing it to look blown out). However, HDR can be successfully toggled off while streaming, which then streams a correct SDR image.cc: @psyke83
Screenshot
Blown out HDR streaming (but better than nothing, which is what you get today)

Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.