feat(input): implement libvirtualhid adding new gamepad styles - #5368
Merged
Conversation
ReenigneArcher
changed the title
Bundle ReportChanges will increase total bundle size by 57.33kB (2.38%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
|
ReenigneArcher
force-pushed
the
libvirtualhid
branch
from
July 3, 2026 04:18
92ddf06 to
d696dca
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5368 +/- ##
==========================================
+ Coverage 28.10% 32.40% +4.30%
==========================================
Files 109 104 -5
Lines 24711 24931 +220
Branches 10910 11076 +166
==========================================
+ Hits 6944 8079 +1135
+ Misses 16783 14999 -1784
- Partials 984 1853 +869
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
libvirtualhid
branch
9 times, most recently
from
July 5, 2026 16:40
b09b74e to
c8d6008
Compare
This was referenced Jul 7, 2026
ReenigneArcher
force-pushed
the
libvirtualhid
branch
5 times, most recently
from
July 8, 2026 15:38
4a64041 to
ed17e4f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ReenigneArcher
force-pushed
the
libvirtualhid
branch
from
July 9, 2026 01:11
ed17e4f to
67787f0
Compare
20 tasks
ReenigneArcher
force-pushed
the
libvirtualhid
branch
7 times, most recently
from
July 15, 2026 12:30
a3e7ed7 to
fe08cf1
Compare
ReenigneArcher
force-pushed
the
libvirtualhid
branch
from
July 30, 2026 01:40
fad67c4 to
e6adb1b
Compare
Screenshot ComparisonPR #5368 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
ReenigneArcher
force-pushed
the
libvirtualhid
branch
6 times, most recently
from
August 10, 2026 19:59
beab94f to
0af629e
Compare
ReenigneArcher
force-pushed
the
libvirtualhid
branch
3 times, most recently
from
August 14, 2026 02:35
c0e7306 to
be323a2
Compare
ReenigneArcher
force-pushed
the
libvirtualhid
branch
from
August 14, 2026 14:13
be323a2 to
f9a9fa8
Compare
This was referenced Aug 14, 2026
ReenigneArcher
force-pushed
the
libvirtualhid
branch
7 times, most recently
from
August 14, 2026 19:47
8694b57 to
23735d6
Compare
ReenigneArcher
force-pushed
the
libvirtualhid
branch
2 times, most recently
from
August 15, 2026 16:35
da01bf8 to
3d2a82d
Compare
Add session-scoped retained input state so virtual gamepads survive paused transport connections and are rebound on resume instead of being recreated. Introduce explicit gamepad termination APIs for global and per-session cleanup, and call them when streams, RTSP sessions, or launched processes are terminated. Add a platform-level `rebind_gamepad` path for both virtualhid and Windows ViGEm backends (with feedback routing synchronization), refactor shared allocation logic, and extend unit coverage for rebind behavior and retained gamepad lifecycle.
Add Linux udev rules that grant input/uaccess permissions to libvirtualhid devices matched by their `phys` path for both `hidraw*` and `event*` nodes, in addition to existing name-based matches. This improves device permission handling when names are inconsistent. Also updates the `third-party/libvirtualhid` submodule to commit `7902b766`.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements libvirtualhid in Sunshine, replacing inputtino on Linux, vigembus on Windows AMD64, and moves the mouse/keyboard input for macOS as well.
We will still falling back to vigembus on Windows ARM64 or in cases where the user doesn't have libvirtualhid's driver installed.
TODO:
b887f6atod28ec79#5414Known issues:
Screenshot
Issues Fixed or Closed
b887f6atod28ec79#5414Roadmap Issues
Type of Change
Checklist
AI Usage