Migrate to upstream Simple-Web-Server submodule#517
Merged
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom Dec 15, 2022
Merged
Migrate to upstream Simple-Web-Server submodule#517ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
ReenigneArcher merged 1 commit intoLizardByte:nightlyfrom
Conversation
10 tasks
Collaborator
Author
|
Looks like Once that is merged (or another fix is committed), I'll update the submodule again and that should fix the build break on those couple broken jobs. |
c305250 to
f74a144
Compare
f74a144 to
8599904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
Simple-Web-Serversubmodule to the upstream actively maintained version. It turns out that all functionality that was specific to our fork was either implemented upstream or could be achieved without modifying theSimple-Web-Servercode itself (by creating a class derived fromSimpleWeb::Server<HTTPS>).Screenshot
Issues Fixed or Closed
Type of Change
Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.