FFmpeg 5 and pre-built CBS

[brad-richardson]

Description

Move to FFmpeg 5 for all builds. The CBS library has been moved upstream to the pre-built repo and is bundled as libcbs.a there, see LizardByte/build-deps#34.

Issues Fixed or Closed

• Resolves FFMPEG dependency update #44

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update (changes to documentation)
• Repository update (changes to repository files)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[ReenigneArcher]

Correct me if I'm wrong, but I don't think is still a breaking change for third-party package maintainers.

[brad-richardson]

Correct me if I'm wrong, but I don't think is still a breaking change for third-party package maintainers.

Maybe not... my thought was that this is now much more tightly coupled to our bundle of dependencies whereas before it could have been changed without too much hassle to link with any ffmpeg build

[psyke83]

Hi,

This PR looks good, except it seems that you've renamed constqp to cqp. Can I ask why? Usually we should try to reference the original names as seen in the ffmpeg source:

ffmpeg -h encoder=hevc_nvenc | grep "QP mode"
     constqp         0            E..V....... Constant QP mode

[brad-richardson]

Hi,

This PR looks good, except it seems that you've renamed constqp to cqp. Can I ask why? Usually we should try to reference the original names as seen in the ffmpeg source:

ffmpeg -h encoder=hevc_nvenc | grep "QP mode"
     constqp         0            E..V....... Constant QP mode

This should have only been changed for the AMF encoders... I'll revert the other changes

[psyke83]

Hi,
This PR looks good, except it seems that you've renamed constqp to cqp. Can I ask why? Usually we should try to reference the original names as seen in the ffmpeg source:

ffmpeg -h encoder=hevc_nvenc | grep "QP mode"
     constqp         0            E..V....... Constant QP mode

This should have only been changed for the AMF encoders... I'll revert the other changes

Thanks! You also don't need to worry about updating the nvenc presets: #623

That PR shouldn't cause any conflicts with your work once you've reverted the cqp change for nvenc.