build(packaging/Arch): fix cuda gcc version detection#4442
Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom Nov 24, 2025
Merged
build(packaging/Arch): fix cuda gcc version detection#4442ReenigneArcher merged 1 commit intoLizardByte:masterfrom
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
Conversation
At this point in time, cuda depends on "gcc" (without any version suffix). This breaks the build, which expects there to always be a version suffix.
28bcb61 to
be9962b
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4442 +/- ##
==========================================
- Coverage 14.25% 14.19% -0.07%
==========================================
Files 89 89
Lines 18942 18942
Branches 8682 8682
==========================================
- Hits 2701 2689 -12
+ Misses 15230 12975 -2255
- Partials 1011 3278 +2267
Flags with carried forward coverage won't be shown. Click here to find out more. |
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
At this point in time, cuda depends on "gcc" (without any version suffix). This breaks the build, which expects there to always be a version suffix.
This PR extends the cuda gcc version detection logic to handle this case, with the expectation that in the future, cuda may be a gcc version behind again. The simpler option would've been to get rid of the gcc version detection logic entirely, but that one may break again in the future.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage