fix(video): fix leaky abstraction in ogl luma shader#4404
fix(video): fix leaky abstraction in ogl luma shader#4404ReenigneArcher merged 1 commit intoLizardByte:masterfrom
Conversation
|
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4404 +/- ##
========================================
Coverage 12.08% 12.08%
========================================
Files 87 87
Lines 17595 17595
Branches 8096 8096
========================================
Hits 2126 2126
- Misses 14566 14748 +182
+ Partials 903 721 -182
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@ReenigneArcher Could you please disable newline linter until it stops triggering on existing code? If I add newline to the modified file, we end up with inconsistent files. If I modify other files too, we end with unrelated git log message. |
|
@ns6089 this linter only runs on modified files. The linter is not intelligent enough to know if the issue existed previously or not. I can ignore the rule for this PR though. Ideally these get fixed over time. |



Description
The shader ignored part of color conversion matrix. Should hopefully fix #4403
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage