Conversation
8221db2 to
15f2b42
Compare
Bundle ReportChanges will increase total bundle size by 1.68kB (0.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sunshine-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4049 +/- ##
==========================================
+ Coverage 11.57% 14.20% +2.63%
==========================================
Files 56 89 +33
Lines 12227 18924 +6697
Branches 5839 8668 +2829
==========================================
+ Hits 1415 2689 +1274
- Misses 10405 14465 +4060
- Partials 407 1770 +1363
Flags with carried forward coverage won't be shown. Click here to find out more.
|
920e292 to
1f75e94
Compare
e820ce8 to
082dc51
Compare
Replaces custom SUNSHINE_USE_SENDSRCADDR macro with standard IP_PKTINFO and IP_SENDSRCADDR checks for better portability. Updates conditional logic for control message buffer allocation and SO_PRIORITY handling to use platform feature detection instead of OS-specific macros.
There was a problem hiding this comment.
@cgutman if you have some time, I'd really appreciate a review on this or at least the 4 comments below.
Edit: I ended up using pre-processors to define them if not defined based on the suggestion from this 16 year old post: https://autoconf.gnu.narkive.com/Q5Crybio/detecting-ip-tos-and-ipproto-ip-vs-sol-ip#post3 ... can't find much else on the topic.
I'm okay with this PR as is and going to merge, but if you find anything after I merge it happy to fix forward.
| echo "Configuring permissions for virtual input devices..." | ||
|
|
||
| # Create the 'input' group if it doesn't exist | ||
| if ! pw groupshow input >/dev/null 2>&1; then |
There was a problem hiding this comment.
Is it okay to use "input" as the group name, or should we create a "sunshine" group instead? I tried to replicate what Linux has, but maybe this isn't the best for BSD.
Revised README to clarify supported controllers and operating systems, including FreeBSD and updated Windows requirements. Updated getting_started.md to note that DualSense/DS5 emulation is not available due to missing uhid features.
|
@danieljg This is ready for you to test now. I've done some basic tests from a FreeBSD VM, but wasn't able to test everything in my environment. Anything else you could test would be terrific.
Unsupported
Artifacts are available here: https://github.com/LizardByte/Sunshine/actions/runs/19266949618#artifacts |
This comment was marked as outdated.
This comment was marked as outdated.
|
@ReenigneArcher Just last week I updated to 15.0-BETA4, now on 15.0-BETA5 on my laptop, hope that won't cause issues, otherwise I'll have to test on my desktop/server (which doesn't have a DE running right now, but it could use one now, I guess). |
The artifact is built against 14.3. I don't know the differences between that and the beta. It might work, or might not. If not you would need to self compile for it to work on 15.0. In the future I'll probably look into including this in the official ports repo. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Awesome, thanks for testing! I'll probably wait a few days before merging this. There will be a few adjustments between this and the final version. I would suggest doing an uninstall before installing new versions to handle cleanup for the differences. |
Changed devfs ruleset marker from comment to [sunshine=10] in install and uninstall scripts for consistency. Removed DS5 gamepad option from FreeBSD platform in Inputs.vue.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
I had success getting audio working from moonlight-embedded, but the mouse is not great on that one, I'll try to debug later today. In any case, this is working, which is great. |
|
According to https://man.freebsd.org/cgi/man.cgi?devfs.rules the rule number should be unique, so I wonder if that was causing you problems before. I'll use a more unique number for sunshine... maybe the default port number for the web ui would be a good candidate. |
|
just in case it's useful, i found the fix was manually setting the sink for the audio as: sink-sunshine-stereo don't know exactly why this was required, but it's possibly because there was another sink for xrdp configured before I'll be sure to install the final package when it's released Hope to be able to test the nvidia P4000 card soon enough Thanks a lot for the hard work, and be sure to let me know if you need any more testing |
Switches devfs ruleset number to 47989 and applies rules immediately during installation if /dev/uinput exists. Improves removal logic in pre-deinstall script by targeting the correct ruleset and cleaning up both file and memory. Enhances reliability and consistency of devfs rules management for Sunshine.
Defines SOL_IP, SOL_IPV6, and SOL_UDP if not present to improve portability. Updates usage of IPPROTO_* constants to SOL_* macros for socket option levels in relevant code paths.
|




Description
This PR adds initial support for FreeBSD.
Issues:
TODO
__u16/kernel type errors - feat(build): fix compilation on BSD games-on-whales/inputtino#30/usr/localsrc/platform/linux/misc.cpphackslocal_addressis empty when trying to start a streaming sessionImprovements for the future:
loader.conffile vmactions/freebsd-vm#106 ... uhid is available on FreeBSD; however doesn't seem to provide auhid.hheader fileScreenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist