build(deps): move nvapi to official NVIDIA repo and bump to R590#3725
Merged
ReenigneArcher merged 3 commits intomasterfrom Mar 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
=========================================
Coverage ? 17.54%
=========================================
Files ? 106
Lines ? 21813
Branches ? 9770
=========================================
Hits ? 3828
Misses ? 15039
Partials ? 2946
Flags with carried forward coverage won't be shown. Click here to find out more.
|
65bb410 to
f9b55fd
Compare
f9b55fd to
8c8a6d8
Compare
Bundle ReportBundle size has no change ✅ |
Prevent NVAPI SAL annotations from being broken when building with GCC/MinGW by defining __NVAPI_EMPTY_SAL before including nvapi.h (so nvapi_lite_salend.h is a no-op transitively) and then explicitly including nvapi_lite_salend.h afterwards to clean up SAL macros. Also move local include (undo_data.h) before NVAPI headers so standard headers are pulled in first, and keep clang-format ordering to preserve header dependency ordering. Update third-party/nvapi submodule commit.
ab2b530 to
dca13f8
Compare
|
qiin2333
pushed a commit
to qiin2333/foundation-sunshine
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR moves to the official nvapi repo, which did not exist at the time ours was created.
R560+ does not build with Sunshine as is, and unfortunately the R555 version in the official repo is missing the
nvapi_interface.hfile. See NVIDIA/nvapi#11Screenshot
Issues Fixed or Closed
cce4e90toc873858#3015Type of Change
.github/...)Checklist