Skip to content

build(deps): move nvapi to official NVIDIA repo and bump to R590#3725

Merged
ReenigneArcher merged 3 commits intomasterfrom
build/deps/move-nvapi-to-official-nvidia-repo
Mar 9, 2026
Merged

build(deps): move nvapi to official NVIDIA repo and bump to R590#3725
ReenigneArcher merged 3 commits intomasterfrom
build/deps/move-nvapi-to-official-nvidia-repo

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 15, 2025

Description

This PR moves to the official nvapi repo, which did not exist at the time ours was created.

R560+ does not build with Sunshine as is, and unfortunately the R555 version in the official repo is missing the nvapi_interface.h file. See NVIDIA/nvapi#11

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@f04f6a2). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3725   +/-   ##
=========================================
  Coverage          ?   17.54%           
=========================================
  Files             ?      106           
  Lines             ?    21813           
  Branches          ?     9770           
=========================================
  Hits              ?     3828           
  Misses            ?    15039           
  Partials          ?     2946           
Flag Coverage Δ
Archlinux 12.05% <ø> (?)
FreeBSD-14.3-amd64 13.87% <ø> (?)
Homebrew-ubuntu-22.04 14.36% <ø> (?)
Linux-AppImage 12.54% <ø> (?)
Windows-AMD64 14.49% <ø> (?)
Windows-ARM64 13.11% <ø> (?)
macOS-arm64 18.22% <ø> (?)
macOS-x86_64 16.72% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/windows/nvprefs/driver_settings.h 100.00% <ø> (ø)

@ReenigneArcher ReenigneArcher force-pushed the build/deps/move-nvapi-to-official-nvidia-repo branch from 65bb410 to f9b55fd Compare July 25, 2025 02:55
@ReenigneArcher ReenigneArcher force-pushed the build/deps/move-nvapi-to-official-nvidia-repo branch from f9b55fd to 8c8a6d8 Compare July 25, 2025 03:06
@codecov
Copy link

codecov bot commented Mar 8, 2026

Bundle Report

Bundle size has no change ✅

Prevent NVAPI SAL annotations from being broken when building with GCC/MinGW by defining __NVAPI_EMPTY_SAL before including nvapi.h (so nvapi_lite_salend.h is a no-op transitively) and then explicitly including nvapi_lite_salend.h afterwards to clean up SAL macros. Also move local include (undo_data.h) before NVAPI headers so standard headers are pulled in first, and keep clang-format ordering to preserve header dependency ordering. Update third-party/nvapi submodule commit.
@ReenigneArcher ReenigneArcher force-pushed the build/deps/move-nvapi-to-official-nvidia-repo branch from ab2b530 to dca13f8 Compare March 9, 2026 00:35
@ReenigneArcher ReenigneArcher removed the help wanted Extra attention is needed label Mar 9, 2026
@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 9, 2026 00:36
@ReenigneArcher ReenigneArcher changed the title build(deps): move nvapi to official nvidia repo build(deps): move nvapi to official nvidia repo and bump to R590 Mar 9, 2026
@LizardByte LizardByte deleted a comment from sonarqubecloud bot Mar 9, 2026
@LizardByte LizardByte deleted a comment from sonarqubecloud bot Mar 9, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

@ReenigneArcher ReenigneArcher changed the title build(deps): move nvapi to official nvidia repo and bump to R590 build(deps): move nvapi to official NVIDIA repo and bump to R590 Mar 9, 2026
@ReenigneArcher ReenigneArcher merged commit 7e3cf70 into master Mar 9, 2026
73 checks passed
@ReenigneArcher ReenigneArcher deleted the build/deps/move-nvapi-to-official-nvidia-repo branch March 9, 2026 02:04
qiin2333 pushed a commit to qiin2333/foundation-sunshine that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants