[Linux Pulse/Pipewire] No sink path *rebased*

[Logical-sh]

Description

This is a resubmit of PR #237 As I made a new branch just in case.
Added some logic so it should handle the case of no default audio sink.
I do not currently have a setup where there are no audio sinks to test this, and am having encoder issues on my current machine, therefore I marked this as draft until further testing can occur.

Issues Fixed or Closed

• Fixes Crash in PulseAudio init on connecting #226

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas

Testing Scenarios

• No sinks on launch (Should create and switch to virtual sink)
• Has a sink, Uses "play audio on host"
• Has a sink, Does not use "play audio on host"

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

[Logical-sh]

@zb140
Can you give this one last pass?
If not I will test soon, but there were no code changes it should just be a sanity check.

[zb140]

@Logical-sh Sure, I'd be happy to. I should be able to do it this evening after work, or if not then, I can definitely do it tomorrow.

[Logical-sh]

Thanks!
Sorry it took so long to get around to!

[zb140]

Just gave it a go, and it's working great 👍

No more crash, I'm seeing the same log as before:

gow-sunshine-1  | [2022:09:17:01:15:08]: Warning: Couldn't find an active default sink. Continuing with virtual audio only.                                     

so we can be confident it's going through the right code path. Thanks all (and particularly @Logical-sh)!

[ReenigneArcher]

@Logical-sh do you think we're good to merge based on the testing by @zb140 ? I don't have the ability to test your scenarios at the moment.

[Logical-sh]

I think so, the rebase was painless. And it was test more before that, so I'd say go for it.