feat(tests): rework tests in numerous ways#3059
Merged
ReenigneArcher merged 2 commits intoLizardByte:masterfrom Aug 22, 2024
Merged
feat(tests): rework tests in numerous ways#3059ReenigneArcher merged 2 commits intoLizardByte:masterfrom
ReenigneArcher merged 2 commits intoLizardByte:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3059 +/- ##
=========================================
- Coverage 7.25% 7.15% -0.10%
=========================================
Files 91 91
Lines 16464 16464
Branches 7785 7780 -5
=========================================
- Hits 1194 1178 -16
- Misses 12672 12687 +15
- Partials 2598 2599 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Added test run details to the log Maybe not the best formatting, but it's fairly easy to change afterwards. |
Contributor
Author
|
Everything is done from my end, if anyone has some issues with particular parts of the PR I can revert them. |
12 tasks
86f7bb2 to
ae2c3e7
Compare
FrogTheFrog
suggested changes
Aug 22, 2024
Contributor
|
LGTM |
Contributor
Author
|
@FrogTheFrog here you go b20d022, one more LGTM please 🐸 |
Contributor
|
LGTM 🐸 |
b20d022 to
0239325
Compare
|
10 tasks
KuleRucket
pushed a commit
to KuleRucket/Sunshine
that referenced
this pull request
Oct 9, 2024
c2vi
pushed a commit
to c2vi/Sunshine
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Architectural
BaseTestclass andTEST()redefinition, tests don't need to derive from it from now onPlatformInitBasethat inherited fromBaseTestwith lightweightPlatformTestSuite, platform initialization/deinitialization is done in static methodsSetUpTestSuite()/TearDownTestSuite()and doesn't interfere with fixture initializationmain()entry point fromgtest_mainLogging
BOOST_LOGtest_sunshine.logcan be uploaded as github actions artifact in CItestshidden behindSUNSHINE_TESTScompile definitionSUNSHINE_TESTScoutmessages toBOOST_LOG(tests)Cosmetics
::testingnamespace withtesting, safeguarding against conflicts is pointless when we should not introduce them in the first placeclasswithstructand dropped all access specifiers, here such access specifiers only add noise0,1,2...to custom names where it was applicableScreenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist