-
-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: adjust clang-format rules #2186
base: master
Are you sure you want to change the base?
Conversation
See https://github.com/LizardByte/Sunshine/actions/runs/8072315274/job/22053784930 for all changes that will be applied when this PR is ready to merge. |
I made a proposal of changes in: |
bc96c71
to
534843f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
======================================
Coverage 8.98% 8.98%
======================================
Files 95 95
Lines 17304 17304
Branches 8232 8232
======================================
Hits 1555 1555
+ Misses 12884 12881 -3
- Partials 2865 2868 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
9f7a6a8
to
938eeb6
Compare
.clang-format
Outdated
BreakBeforeTernaryOperators: false | ||
BreakConstructorInitializers: AfterColon | ||
BreakInheritanceList: AfterColon | ||
ColumnLimit: 0 | ||
ColumnLimit: 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really work the way I wish it would... probably revert this to 0
ColumnLimit: 120 | |
ColumnLimit: 0 |
938eeb6
to
5f931d2
Compare
Co-Authored-By: Vithorio Polten <[email protected]>
5f931d2
to
90f6aec
Compare
Description
Adjust clang-format rules, mostly to adjust break after return type behavior.
Screenshot
Issues Fixed or Closed
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.