Skip to content

fix(ui): fix missing favicon#1972

Merged
ReenigneArcher merged 1 commit intonightlyfrom
fix(ui)-fix-missing-favicon
Jan 2, 2024
Merged

fix(ui): fix missing favicon#1972
ReenigneArcher merged 1 commit intonightlyfrom
fix(ui)-fix-missing-favicon

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 2, 2024

Description

This fixes a missing favicon in the web ui. I think this bug was introduced in #1673, and something was missed after rebasing the PR #1736, where the glob pattern changed.

An alternative fix is to adjust the glob pattern back to server.resource["^/images/favicon.ico$"]["GET"] = getFaviconImage;

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher marked this pull request as ready for review January 2, 2024 03:57
@ReenigneArcher
Copy link
Member Author

I'll merge this. If any devs think we should change the glob pattern instead we can change the behavior in a secondary PR.

KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants