Skip to content

Fix incorrect portrait mode rotation center on Windows #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 2 commits into from
Nov 17, 2023
Merged

Fix incorrect portrait mode rotation center on Windows #1851

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553988a
Minor consistency cosmetics in shader
ns6089 Nov 17, 2023
16857a4
Fix incorrect portrait rotation center in shader
ns6089 Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src_assets/windows/assets/shaders/directx/include/base_vs.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#if defined(LEFT_SUBSAMPLING)
vertex_t generate_fullscreen_triangle_vertex(uint vertex_id, float subsample_offset, int rotate_texture_steps)
#elif defined (TOPLEFT_SUBSAMPLING)
#elif defined(TOPLEFT_SUBSAMPLING)
vertex_t generate_fullscreen_triangle_vertex(uint vertex_id, float2 subsample_offset, int rotate_texture_steps)
#else
vertex_t generate_fullscreen_triangle_vertex(uint vertex_id, int rotate_texture_steps)
Expand All @@ -29,7 +29,7 @@ vertex_t generate_fullscreen_triangle_vertex(uint vertex_id, int rotate_texture_
float2x2 rotation_matrix = { cos(rotation_radians), -sin(rotation_radians),
sin(rotation_radians), cos(rotation_radians) };
float2 rotation_center = { 0.5, 0.5 };
tex_coord = round(tex_coord + mul(rotation_matrix, tex_coord - rotation_center));
tex_coord = round(rotation_center + mul(rotation_matrix, tex_coord - rotation_center));
}

#if defined(LEFT_SUBSAMPLING)
Expand Down