Add Support for Safely Elevating Administrator Privileges#1036
Merged
ReenigneArcher merged 15 commits intoLizardByte:nightlyfrom Mar 27, 2023
Merged
Add Support for Safely Elevating Administrator Privileges#1036ReenigneArcher merged 15 commits intoLizardByte:nightlyfrom
ReenigneArcher merged 15 commits intoLizardByte:nightlyfrom
Conversation
|
Your PR was set to |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
3 tasks
Member
|
Regarding #764, that error occurs for me when I don't use Didn't have anything to do with elevation in my experience. |
This comment was marked as spam.
This comment was marked as spam.
ReenigneArcher
requested changes
Mar 16, 2023
Member
ReenigneArcher
left a comment
There was a problem hiding this comment.
Haven't tested this, but overall the code looks good. Just have a few minor suggestions.
bf7f5a7 to
19991d2
Compare
ReenigneArcher
previously approved these changes
Mar 17, 2023
Member
|
Depends on #1022 |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
…he command using PowerShell forcing a UAC prompt.
…egardless if 740 or not
…o why a tool needs to be used Powershell is no longer a dependency
7133e1a to
0beb940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sunshine will be able to detect if a command failed due to lack of elevation and will try again in an elevated context.
It does it in a safer manner, forcing a UAC prompt and user interaction.
As a bonus, when #998 is fixed as well, this will work for the pre-commands as well.
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.