Always add content after parentheses in extended category #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to see some tests here. |
|
Uhm what |
|
Not sure what's going on here: |
|
They yanked the new major version that they released. It probably had a major bug. But lmao, that's an oversight on cargo's implementation imo. Yanking a whole major version range shouldn't be possible. |
|
@wooferzfg Can you basically revert #394 as part of this? |
|
Seems like this is the cause: rust-lang/hashbrown#225 |
wooferzfg
force-pushed
the
fix-extended-category
branch
from
da38fa9
to
483e4fe
Compare
CryZe
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I'm missing an edge case with this fix, but this should only impact situations where
has_pushedisfalse, which only happens when no additional information is added to the extended category name.Fix #391