More tests by beto-rodriguez · Pull Request #2096 · Live-Charts/LiveCharts2

beto-rodriguez · 2026-02-12T20:11:47Z

No description provided.

github-actions · 2026-02-12T20:12:01Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
✅ passed	❌ failed	❌ failed	❌ failed	❌ failed	❌ failed	❌ failed

0 skipped.
561 passed.
85 failed. ❌

Copilot

Pull request overview

This PR adds GPU/hardware acceleration tests and improves test organization. It introduces a new RendererName property to CoreMotionCanvas to enable testing of different rendering modes, adds tests for both CPU and GPU rendering in PieChartTests and CartesianChartTests, and consolidates Avalonia-specific tests by moving the virtualization test from a dedicated AvaloniaTests.cs file into CartesianChartTests.cs.

Changes:

Added RendererName property to CoreMotionCanvas for renderer identification
Added GPU rendering tests (ShouldLoadHardwareAcceleratedView) to verify hardware acceleration works correctly
Enhanced existing tests to verify CPU rendering by default
Consolidated Avalonia virtualization test into CartesianChartTests.cs and removed AvaloniaTests.cs
Updated build configuration comments to clarify GPU/VSYNC settings

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tests/SharedUITests/PieChartTests.cs	Added GPU rendering test and CPU rendering verification to existing test
tests/SharedUITests/CartesianChartTests.cs	Added GPU rendering test, CPU rendering verification, and moved Avalonia virtualization test
tests/SharedUITests/AvaloniaTests.cs	Removed file - test moved to CartesianChartTests.cs
src/LiveChartsCore/Motion/CoreMotionCanvas.cs	Added public RendererName property to expose renderer information
Directory.Build.props	Updated comments to clarify GPU configuration options

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T20:18:43Z

        var sut = await App.NavigateTo<Samples.General.FirstChart.View>();
        await sut.Chart.WaitUntilChartRenders();

+        Assert.DoesNotContain(sut.Chart.CoreCanvas.RendererName, "GPU");


This assertion assumes that GPU rendering is not enabled by default. However, if the ShouldLoadHardwareAcceleratedView test runs before this test and fails to restore settings, this assertion could fail. Consider making this test more resilient by explicitly setting the GPU mode to false at the start of the test, or ensuring proper test isolation.

github-actions · 2026-02-12T20:51:13Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
✅ passed	❌ failed	✅ passed	✅ passed	✅ passed	✅ passed	✅ passed

0 skipped.
1096 passed.
9 failed. ❌

github-actions · 2026-02-12T21:40:43Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
✅ passed	❌ failed	✅ passed	✅ passed	✅ passed	✅ passed	✅ passed

0 skipped.
1790 passed.
4 failed. ❌

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-12T21:47:12Z

+        var sut = await App.NavigateTo<Samples.Pies.Basic.View>();
+        await sut.Chart.WaitUntilChartRenders();
+
+        Assert.Contains("GPU", sut.Chart.CoreCanvas.RendererName);
+        Assert.ChartIsLoaded(sut.Chart);
+
+        // restore default settings for other tests
+        LiveChartsCore.LiveCharts.Configure(config => config.HasRenderingSettings(builder => builder.UseGPU = false));


The test modifies global configuration (LiveCharts.Configure) and relies on cleanup code at the end. If the test fails or is interrupted before line 74, the GPU setting will remain enabled, potentially affecting subsequent tests. Consider using a try-finally block to ensure the configuration is always restored, or implement IDisposable/IAsyncLifetime for proper test cleanup.

Suggested change

var sut = await App.NavigateTo<Samples.Pies.Basic.View>();

await sut.Chart.WaitUntilChartRenders();

Assert.Contains("GPU", sut.Chart.CoreCanvas.RendererName);

Assert.ChartIsLoaded(sut.Chart);

// restore default settings for other tests

LiveChartsCore.LiveCharts.Configure(config => config.HasRenderingSettings(builder => builder.UseGPU = false));

try

{

var sut = await App.NavigateTo<Samples.Pies.Basic.View>();

await sut.Chart.WaitUntilChartRenders();

Assert.Contains("GPU", sut.Chart.CoreCanvas.RendererName);

Assert.ChartIsLoaded(sut.Chart);

}

finally

{

// restore default settings for other tests

LiveChartsCore.LiveCharts.Configure(config => config.HasRenderingSettings(builder => builder.UseGPU = false));

}

Copilot · 2026-02-12T21:47:12Z

+        var sut = await App.NavigateTo<Samples.General.FirstChart.View>();
+        await sut.Chart.WaitUntilChartRenders();
+
+        Assert.Contains("GPU", sut.Chart.CoreCanvas.RendererName);
+        Assert.ChartIsLoaded(sut.Chart);
+
+        // restore default settings for other tests
+        LiveChartsCore.LiveCharts.Configure(config => config.HasRenderingSettings(builder => builder.UseGPU = false));


The test modifies global configuration (LiveCharts.Configure) and relies on cleanup code at the end. If the test fails or is interrupted before line 120, the GPU setting will remain enabled, potentially affecting subsequent tests. Consider using a try-finally block to ensure the configuration is always restored, or implement IDisposable/IAsyncLifetime for proper test cleanup.

Suggested change

var sut = await App.NavigateTo<Samples.General.FirstChart.View>();

await sut.Chart.WaitUntilChartRenders();

Assert.Contains("GPU", sut.Chart.CoreCanvas.RendererName);

Assert.ChartIsLoaded(sut.Chart);

// restore default settings for other tests

LiveChartsCore.LiveCharts.Configure(config => config.HasRenderingSettings(builder => builder.UseGPU = false));

try

{

var sut = await App.NavigateTo<Samples.General.FirstChart.View>();

await sut.Chart.WaitUntilChartRenders();

Assert.Contains("GPU", sut.Chart.CoreCanvas.RendererName);

Assert.ChartIsLoaded(sut.Chart);

}

finally

{

// restore default settings for other tests

LiveChartsCore.LiveCharts.Configure(config => config.HasRenderingSettings(builder => builder.UseGPU = false));

}

Copilot · 2026-02-12T21:47:12Z


  <!--
-  used to test the library on multiple render modes,
+  used to test the library on multiple render modes, this config overrides the the settings defined by the user.


The phrase "overrides the the settings" contains a duplicate word "the". It should be "overrides the settings".

Suggested change

used to test the library on multiple render modes, this config overrides the the settings defined by the user.

used to test the library on multiple render modes, this config overrides the settings defined by the user.

github-actions · 2026-02-12T22:01:04Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
✅ passed	❌ failed	✅ passed	❌ failed	✅ passed	✅ passed	✅ passed

0 skipped.
1671 passed.
6 failed. ❌

github-actions · 2026-02-12T22:20:52Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
#	❌ failed	#	#	#	#	#

0 skipped.
3 passed.
1 failed. ❌

This reverts commit 08ebf40.

github-actions · 2026-02-12T23:09:46Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Passed) ✅ 🥳

0 skipped.
0 failed.
1637 passed! ✅

github-actions · 2026-02-13T01:54:04Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
✅ passed	✅ passed	✅ passed	✅ passed	❌ failed	⚠️ cancelled	⚠️ cancelled

0 skipped.
1348 passed.
0 failed. ❌

beto-rodriguez · 2026-02-13T02:04:54Z

@copilot can you implement actions/cache@v5.0.3 into the .github/actions/detup-dotnet-and-workloads so it caches the used workloads?

Copilot · 2026-02-13T02:05:03Z

@beto-rodriguez I've opened a new pull request, #2097, to work on those changes. Once the pull request is ready, I'll request review from you.

github-actions · 2026-02-13T15:03:35Z

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.

All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.

Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Failure) ❌ 😥

Core	Windows	Linux	Mac	Browser	Android	iOS
✅ passed	✅ passed	✅ passed	✅ passed	❌ failed	✅ passed	✅ passed

0 skipped.
3332 passed.
0 failed. ❌

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (4)

src/LiveChartsCore/Motion/CoreMotionCanvas.cs:183

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

                    foreach (var geometry in task.GetGeometries(this))
                    {
                        if (geometry is null) continue;
                        if (DisableAnimations) geometry.CompleteTransition(null);

                        geometry.IsValid = true;

                        if (!task.IsPaused)
                        {
                            context.ActiveOpacity = geometry.Opacity;
                            context.Draw(geometry);
                        }

                        isValid = isValid && geometry.IsValid;

                        if (geometry.IsValid && geometry.RemoveOnCompleted)
                            toRemoveGeometries.Add(
                                new Tuple<Paint, IDrawnElement>(task, geometry));
                    }

src/LiveChartsCore/Motion/CoreMotionCanvas.cs:339

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

        foreach (var zone in Zones)
            if (zone.RemoveTask(task))
                break;

src/LiveChartsCore/Motion/CoreMotionCanvas.cs:387

This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.

        foreach (var zone in Zones)
            if (zone.ContainsTask(task))
                return true;

src/LiveChartsCore/Motion/CoreMotionCanvas.cs:360

This assignment to geometry is useless, since its value is never read.

            foreach (var geometry in task.GetGeometries(this))

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T19:20:45Z

+  <PropertyGroup Condition="$(TestBuildTargetFramework) == 'net10.0-windows'">
+    <!--
+    workaround, not sure why hardware accelerated views is failing on net10.0-windows10.0.19041.0 in CI environments
+    im not able top reproduce the issue locally, ill assume for now that it is a false positive and just exclude that
+    hardware accelerated tests in this target.
+    -->
+    <DefineConstants>$(DefineConstants);TEST_HA_VIEWS</DefineConstants>


The logic in this conditional compilation symbol definition appears inverted. The comment says the hardware accelerated views are failing on net10.0-windows in CI, so tests should be excluded. However, the code defines TEST_HA_VIEWS (suggesting tests should be included) when the target framework is net10.0-windows. This appears to be backwards - if tests are failing, the symbol should NOT be defined, or the conditional checks should use a different symbol like SKIP_HA_VIEWS.

Copilot · 2026-02-13T19:20:45Z

+  <PropertyGroup Condition="$(TestBuildTargetFramework) == 'net10.0-windows'">
+    <!--
+    workaround, not sure why hardware accelerated views is failing on net10.0-windows10.0.19041.0 in CI environments
+    im not able top reproduce the issue locally, ill assume for now that it is a false positive and just exclude that


There are grammatical issues in this comment: "im" should be "I'm" and "ill" should be "I'll".

Suggested change

im not able top reproduce the issue locally, ill assume for now that it is a false positive and just exclude that

I'm not able to reproduce the issue locally, I'll assume for now that it is a false positive and just exclude that

Copilot · 2026-02-13T19:20:46Z

          test-id: ${{ matrix.id }}
          workloads: ${{ matrix.workloads }}
-          # target-framework: ${{ matrix.tf }}
+          target-framework: ${{ matrix.tf }}


The target-framework parameter is now being passed for all test-browser matrix entries, but the avalonia-browser entry doesn't define a 'tf' value in its matrix configuration. This means target-framework will be passed as an empty string to the run-tests action. Verify that the run-tests action handles empty or undefined target-framework values correctly, or add a tf value to the avalonia-browser matrix entry if it needs one.

Copilot · 2026-02-13T19:20:46Z

        include:
-          # - id: avalonia-ios
-          #   workloads: ios
+          - id: avalonia-ios


The avalonia-ios test has been re-enabled but doesn't define a 'tf' (target framework) value in its matrix configuration, while the run-tests action is called with target-framework: ${{ matrix.tf }} on line 319. This means an empty string will be passed for target-framework. Verify that the run-tests action handles empty target-framework values correctly, or add a tf value to the avalonia-ios matrix entry if required.

Suggested change

- id: avalonia-ios

- id: avalonia-ios

tf: net10.0-ios

Copilot · 2026-02-13T19:20:46Z


  <!--
-  used to test the library on multiple render modes,
+  used to test the library on multiple render modes, this config overrides the the settings defined by the user.


There is a typo in the comment: "the the" should be just "the".

Suggested change

used to test the library on multiple render modes, this config overrides the the settings defined by the user.

used to test the library on multiple render modes, this config overrides the settings defined by the user.

beto-rodriguez added 2 commits February 12, 2026 14:10

add gpu tests

e5871d8

update directory.build.props

ce482fd

Copilot AI review requested due to automatic review settings February 12, 2026 20:11

Copilot started reviewing on behalf of beto-rodriguez February 12, 2026 20:12 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

.

85cf874

.

06fce47

Copilot AI review requested due to automatic review settings February 12, 2026 21:40

Copilot started reviewing on behalf of beto-rodriguez February 12, 2026 21:40 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

beto-rodriguez marked this pull request as draft February 12, 2026 21:48

.

62d1408

test

08ebf40

beto-rodriguez added 2 commits February 12, 2026 16:49

Revert "test"

06817e2

This reverts commit 08ebf40.

.

5957632

.

09b2fa1

Copilot AI mentioned this pull request Feb 13, 2026

Add workload caching to GitHub Actions setup #2097

Closed

6 tasks

.

a275efe

beto-rodriguez added 2 commits February 13, 2026 09:36

.

0714038

remove some warnings in ui tests for cleaner logs

7486d37

Copilot AI reviewed Feb 13, 2026

View reviewed changes

This was referenced Apr 10, 2026

Bump LiveChartsCore.SkiaSharpView.Avalonia from 2.0.0-rc6.1 to 2.0.0 soliktomasz/BusLane#84

Merged

Bump the all-dependencies group with 8 updates RolandKoenig/GpxViewer2#76

Merged

This was referenced May 2, 2026

Bump the nuget-updates group with 5 updates millenniumsingha/real-time-info-dashboard#61

Closed

Bump LiveChartsCore from 2.0.0-rc6.1 to 2.0.2 JustAman62/undercut-f1#229

Closed

Bump LiveChartsCore and LiveChartsCore.SkiaSharpView JustAman62/undercut-f1#230

Open

dependabot Bot mentioned this pull request May 16, 2026

Bump the nuget-updates group with 5 updates millenniumsingha/real-time-info-dashboard#63

Open

dependabot Bot mentioned this pull request Jun 1, 2026

Bump LiveChartsCore.SkiaSharpView.WPF from 2.0.0-rc5.4 to 2.0.4 Cacsjep/mscp#127

Merged

This was referenced Jun 11, 2026

Bump LiveChartsCore.SkiaSharpView.WPF from 2.0.0-rc3.3 to 2.0.4 SysAdminDoc/win11-nvme-driver-patcher#6

Closed

Bump the dotnet-dependencies group with 9 updates Progressiverobot/hmailserver#3

Closed

This was referenced Jun 19, 2026

Bump LiveChartsCore.SkiaSharpView.WPF and 8 others Progressiverobot/hmailserver#4

Closed

Bump the dotnet-dependencies group with 11 updates Progressiverobot/hmailserver#5

Closed

dependabot Bot mentioned this pull request Jul 1, 2026

Bump LiveChartsCore.SkiaSharpView.WPF from 2.0.0-rc5.4 to 2.0.5 Cacsjep/mscp#161

Closed

This was referenced Jul 8, 2026

Bump LiveChartsCore.SkiaSharpView.Avalonia from 2.0.0-rc6.1 to 2.0.5 one-ware/OneWare#281

Merged

Bump LiveChartsCore.SkiaSharpView.WPF and 10 others Progressiverobot/hmailserver#8

Closed

dependabot Bot mentioned this pull request Jul 27, 2026

chore(deps): Bump BCrypt.Net-Next and 18 others nleceguic/rush-order#9

Open

dependabot Bot mentioned this pull request Aug 13, 2026

chore(deps): Bump BCrypt.Net-Next and 16 others nleceguic/rush-order#13

Open

	used to test the library on multiple render modes, this config overrides the the settings defined by the user.
	used to test the library on multiple render modes, this config overrides the settings defined by the user.

	im not able top reproduce the issue locally, ill assume for now that it is a false positive and just exclude that
	I'm not able to reproduce the issue locally, I'll assume for now that it is a false positive and just exclude that

Uh oh!

Conversation

beto-rodriguez commented Feb 12, 2026

Uh oh!

github-actions Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

github-actions Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

github-actions Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

github-actions Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Passed) ✅ 🥳

Uh oh!

github-actions Bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

beto-rodriguez commented Feb 13, 2026

Uh oh!

Copilot AI commented Feb 13, 2026

Uh oh!

github-actions Bot commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary (Failure) ❌ 😥

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

github-actions Bot commented Feb 12, 2026 •

edited

Loading

github-actions Bot commented Feb 12, 2026 •

edited

Loading

github-actions Bot commented Feb 12, 2026 •

edited

Loading

github-actions Bot commented Feb 12, 2026 •

edited

Loading

github-actions Bot commented Feb 12, 2026 •

edited

Loading

github-actions Bot commented Feb 12, 2026 •

edited

Loading

github-actions Bot commented Feb 13, 2026 •

edited

Loading

github-actions Bot commented Feb 13, 2026 •

edited

Loading