Fix stack calculation for positive and negative values - #2085
Merged
beto-rodriguez merged 3 commits intoFeb 8, 2026
Conversation
Fix: The Negative+Positive values are not calculated correctly for the stacked graphics
Contributor
Author
|
The Unit Test show bellow. Has some config error in github action config? Error: C:\Program Files\dotnet\sdk\9.0.310\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets(38,5): error NETSDK1202: The workload 'net8.0-ios' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/maui-support-policy for more information about the support policy. [D:\a\LiveCharts2\LiveCharts2\src\skiasharp\LiveChartsCore.SkiaSharp\LiveChartsCore.SkiaSharpView.csproj::TargetFramework=net8.0-ios] |
Collaborator
This was referenced Apr 2, 2026
Closed
This was referenced Apr 10, 2026
This was referenced Apr 18, 2026
3 tasks
pull Bot
pushed a commit
to zilo555/LiveCharts2
that referenced
this pull request
Apr 26, 2026
… signs PR Live-Charts#2085 fixed stacked area with mixed signs (Live-Charts#2073) by accumulating every value into both End and NegativeEnd. That gave area charts an Excel-like continuous baseline but broke stacked column/row series (Live-Charts#2152): a positive bar above a previous negative value started at the negative end instead of 0. Column/row stacks need positives and negatives in separate streams (each grows from 0 in its own direction). Area/line stacks need a single running total to keep the baseline continuous when values cross zero. Stacker now exposes both: End/NegativeEnd are sign-segregated again, and a new CumulativeStart/CumulativeEnd track always accumulates regardless of sign. CoreLineSeries and CoreStepLineSeries read the cumulative track when stacked. Snapshot regressions added for Live-Charts#2073 and Live-Charts#2152. The previous StackedColumnsTests_Basic baseline was captured under the buggy behavior and has been regenerated. The CoreTests ShouldHandleMixedPositiveNegativeValues tests for stacked area / step area, which had been written to assert PR Live-Charts#2085's broken numbers, now assert the correct dual-track + cumulative semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Jun 11, 2026
This was referenced Jun 19, 2026
This was referenced Jul 8, 2026
This was referenced Jul 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: The Negative+Positive values are not calculated correctly for the stacked graphics
issue 2073