Fix uno win target - #2080
Conversation
|
Thanks for your contribution! The build and test process is starting. This may take a while. Test Results Summary (Failure) ❌ 😥
0 skipped. |
There was a problem hiding this comment.
Pull request overview
This pull request fixes a compilation error in the Uno Platform sample by correcting the Windows target framework version from an invalid value to the standard version used across the codebase.
Changes:
- Updated Windows target framework from
net10.0-windows10.0.26100tonet10.0-windows10.0.19041.0in the UnoPlatformSample project - Added a new CI test matrix entry for testing the Uno Platform with the WinUI-specific target framework
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| samples/UnoPlatformSample/UnoPlatformSample/UnoPlatformSample.csproj | Corrects the Windows target framework to match the standard version used across all other Windows samples (WinUI, WPF, WinForms, MAUI) |
| .github/workflows/livecharts.yml | Adds CI testing for the Uno Platform with Windows-specific target framework |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thanks for your contribution! The build and test process is starting. This may take a while. All packages have been packed successfully! 📦✅ The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org. Tests will start now, you can monitor their progress below or at the actions tab. Test Results Summary (Failure) ❌ 😥
0 skipped. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for your contribution! The build and test process is starting. This may take a while. All packages have been packed successfully! 📦✅ The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org. Tests will start now, you can monitor their progress below or at the actions tab. Test Results Summary (Passed) ✅ 🥳0 skipped. Test Results Summary (Passed) ✅ 🥳0 skipped. |
|
Thanks for your contribution! The build and test process is starting. This may take a while. All packages have been packed successfully! 📦✅ The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org. Tests will start now, you can monitor their progress below or at the actions tab. Test Results Summary (Passed) ✅ 🥳0 skipped. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| max_attempts: 3 | ||
| shell: pwsh | ||
| command: dotnet run --project tests/UITests -c Release --report-trx --no-progress --select ${{ inputs.test-id }} --test-env tf=${{ inputs.target-framework }} lvcversionsuffix=-${{ github.sha }} | ||
| command: dotnet run --project tests/UITests -c Release --report-trx --report-trx-filename results.trx --no-progress --select ${{ inputs.test-id }} --test-env tf=${{ inputs.target-framework }} lvcversionsuffix=-${{ github.sha }} |
There was a problem hiding this comment.
The --report-trx-filename results.trx parameter was added to the regular UI tests command, but the Android emulator test command on line 80 is missing this parameter. This creates an inconsistency between the two test execution paths. For consistency and to ensure both test types generate TRX files with the same naming pattern, the Android emulator test command should also include --report-trx-filename results.trx.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@beto-rodriguez I've opened a new pull request, #2081, to work on those changes. Once the pull request is ready, I'll request review from you. |
In a previous commit the Uno target framework was updated from
net10.0-windows10.0.26100tonet10.0-windows10.0.19041.0, that solves #2005. This PR adds a UI test against net10.0-windows10.0.19041.0 to ensure that the library compiles and passes tests against that target.