Fix lineseries remove last 2040 - #2077
Conversation
|
Thanks for your contribution! The build and test process is starting. This may take a while. All packages have been packed successfully! 📦✅ The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org. Tests will start now, you can monitor their progress below or at the actions tab. Test Results Summary (Passed) ✅ 🥳0 skipped. |
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #2040 where LineSeries displays "ghost points" or artifacts when the Values collection is updated with fewer points than the previous dataset. The problem occurred because old Bezier segment control points remained in the path collections after points were removed.
Changes:
- Adds explicit removal of segments from stroke and fill path collections when disposing points in LineSeries
- Adds comprehensive test coverage to validate bezier scaling behavior when points are added, removed, or inserted
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/LiveChartsCore/CoreLineSeries.cs | Adds segment cleanup logic to SoftDeleteOrDisposePoint method to remove disposed point segments from stroke and fill path collections |
| tests/CoreTests/SeriesTests/LineSeriesTest.cs | Adds new test ShouldScaleBeziersOnAddRemoveOrInsert to validate straight line rendering after various point manipulations; removes unused imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Thanks for your contribution! The build and test process is starting. This may take a while. All packages have been packed successfully! 📦✅ The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org. Tests will start now, you can monitor their progress below or at the actions tab. Test Results Summary (Passed) ✅ 🥳0 skipped. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for your contribution! The build and test process is starting. This may take a while. All packages have been packed successfully! 📦✅ The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org. Tests will start now, you can monitor their progress below or at the actions tab. Test Results Summary (Passed) ✅ 🥳0 skipped. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensures line series removes points on points disposing