Skip to content

Fix lineseries remove last 2040 - #2077

Merged
beto-rodriguez merged 4 commits into
devfrom
fix-lineseries-remove-last-2040
Jan 31, 2026
Merged

Fix lineseries remove last 2040#2077
beto-rodriguez merged 4 commits into
devfrom
fix-lineseries-remove-last-2040

Conversation

@beto-rodriguez

@beto-rodriguez beto-rodriguez commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

@github-actions

github-actions Bot commented Jan 30, 2026

Copy link
Copy Markdown

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.


All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.


Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Passed) ✅ 🥳

0 skipped.
0 failed.
742 passed! ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes issue #2040 where LineSeries displays "ghost points" or artifacts when the Values collection is updated with fewer points than the previous dataset. The problem occurred because old Bezier segment control points remained in the path collections after points were removed.

Changes:

  • Adds explicit removal of segments from stroke and fill path collections when disposing points in LineSeries
  • Adds comprehensive test coverage to validate bezier scaling behavior when points are added, removed, or inserted

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/LiveChartsCore/CoreLineSeries.cs Adds segment cleanup logic to SoftDeleteOrDisposePoint method to remove disposed point segments from stroke and fill path collections
tests/CoreTests/SeriesTests/LineSeriesTest.cs Adds new test ShouldScaleBeziersOnAddRemoveOrInsert to validate straight line rendering after various point manipulations; removes unused imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/CoreTests/SeriesTests/LineSeriesTest.cs Outdated
Comment thread tests/CoreTests/SeriesTests/LineSeriesTest.cs
Comment thread src/LiveChartsCore/CoreLineSeries.cs
Comment thread tests/CoreTests/SeriesTests/LineSeriesTest.cs
Comment thread tests/CoreTests/SeriesTests/LineSeriesTest.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 30, 2026 23:17
@github-actions

github-actions Bot commented Jan 30, 2026

Copy link
Copy Markdown

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.


All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.


Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Passed) ✅ 🥳

0 skipped.
0 failed.
663 passed! ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/CoreTests/SeriesTests/LineSeriesTest.cs
@github-actions

github-actions Bot commented Jan 30, 2026

Copy link
Copy Markdown

Thanks for your contribution!

The build and test process is starting. This may take a while.
You can find more details below as the process continues or at the actions tab.


All packages have been packed successfully! 📦✅
You can download the NuGet packages for this build here.

The packages will be available for 30 days, you can either use them directly, or wait for this PR to be merged to have them published to NuGet.org.


Tests will start now, you can monitor their progress below or at the actions tab.

Test Results Summary (Passed) ✅ 🥳

0 skipped.
0 failed.
941 passed! ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/CoreTests/SeriesTests/StepLineSeriesTest.cs
Comment thread src/LiveChartsCore/CoreLineSeries.cs
Comment thread tests/CoreTests/SeriesTests/StepLineSeriesTest.cs
Comment thread tests/CoreTests/SeriesTests/StepLineSeriesTest.cs
@beto-rodriguez
beto-rodriguez merged commit 2f3ba73 into dev Jan 31, 2026
42 checks passed
@beto-rodriguez
beto-rodriguez deleted the fix-lineseries-remove-last-2040 branch January 31, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants