Uno packing - #1969
Merged
Merged
Uno packing#1969
Conversation
Introduce `UseNuGetForSamples` and `UseNuGetForGenerator` properties in `Directory.Build.props` to manage dependencies across multiple platforms (Avalonia, Blazor, Eto, Maui, Uno, WPF, WinForms, WinUI). Update sample project files to conditionally reference NuGet packages or project references based on these properties. Add warning suppression in `PointerController.cs` and standardize chart view implementations in `SourceGenCartesianChart.cs`, `SourceGenPieChart.cs`, and `SourceGenPolarChart.cs` by using a new alias `SGChart`. These changes enhance flexibility and maintainability of the LiveCharts library.
ensures uno skiarenderer is packed to netx.x, and native renderers are packed when at netx.x-os
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the Uno Platform package to support both the SkiaRenderer and native renderer implementations for LiveCharts. The changes introduce flexible build configurations that allow choosing between the SkiaSharp-based rendering system and the native OS-specific rendering system based on the target platform.
Key changes include:
- Updated chart base classes to use a unified
SGChartbase class across both Skia and native rendering modes - Introduced conditional compilation directives (
HAS_OS_LVC,UNO_LVC) to separate platform-specific code paths - Added support for both NuGet package references and project references through build-time configuration
Reviewed Changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SourceGenPolarChart.cs | Updates base class inheritance to use unified SGChart |
| SourceGenPieChart.cs | Updates base class inheritance to use unified SGChart |
| SourceGenCartesianChart.cs | Updates base class inheritance to use unified SGChart |
| MotionCanvas.cs | Adds conditional compilation for renderer selection |
| SkiaRenderMode.cs | Updates conditional compilation and namespace |
| Multiple .csproj files | Adds conditional package/project reference support |
| _Shared.Native.projitems | Reorganizes platform-specific file includes |
| Platform-specific controllers | Updates conditional compilation directives |
| New UnoSkiaRenderer files | Adds Uno-specific SkiaRenderer implementation |
| Build configuration files | Updates build properties and removes deprecated settings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables uno package to use the SkiaRenderer or the native renderer (LiveCharts implementation).