PieChart (and PolarChart) custom legend support (#1489) - #1573
Merged
Conversation
…ot overriding the legend in the InitializeCore method (Fixes Live-Charts#1489)
nadav26740
approved these changes
Sep 4, 2024
nadav26740
left a comment
nadav26740
left a comment
There was a problem hiding this comment.
looks good and it's seems like there has been no actual reason for it to be reinitialized
beto-rodriguez
approved these changes
Sep 11, 2024
Collaborator
|
Thaks for the PR! I missed that in #859!! |
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1489
The default
legendassignment inInitializeCorewas overwriting the user-provided legend. Moving this to the constructor, similar to how thetooltipis managed, yields the desired results.Example using the Custom Legend example in the
WPFSampleproject:Before:
After:
